Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composable variant of builtins.path #34699

Closed
wants to merge 1 commit into from
Closed

Add composable variant of builtins.path #34699

wants to merge 1 commit into from

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Feb 7, 2018

No description provided.

@shlevy
Copy link
Member Author

shlevy commented Feb 7, 2018

@ElvishJerricco PTAL

@edolstra
Copy link
Member

edolstra commented Feb 7, 2018

Ugh, this is so ugly, with all the question marks operators, ors, nulls, optionalAttrs, ... Do we really need this?

@shlevy
Copy link
Member Author

shlevy commented Feb 7, 2018

Yeah, we need composable filtering for callCabal2nix (the original motivation behind cleanSourceWith) and we need to be able to specify the name for nix-illegal paths (the original motivation behind me adding builtins.path).

@shlevy shlevy closed this Mar 18, 2018
@shlevy shlevy deleted the composable-path branch March 18, 2018 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shlevy @edolstra @GrahamcOfBorg