Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.09] mpv: fix CVE-2018-6460 #34693

Merged
merged 1 commit into from Feb 7, 2018
Merged

[17.09] mpv: fix CVE-2018-6460 #34693

merged 1 commit into from Feb 7, 2018

Conversation

andir
Copy link
Member

@andir andir commented Feb 7, 2018

Motivation for this change

Upstream has fixed this in a series of commits ontop of 0.28.0. Debian
has backported the fixes to 0.27.0.

Upstream issue: mpv-player/mpv#5456
Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888654#8

(cherry picked from commit 95f4d6b)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
mpv: fix CVE-2018-6460
5b18585 
Upstream has fixed this in a series of commits ontop of 0.28.0. Debian
has backported the fixes to 0.27.0.

Upstream issue: mpv-player/mpv#5456
Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888654#8

(cherry picked from commit 95f4d6b)
@andir
Copy link
Member Author

andir commented Feb 7, 2018

@GrahamcOfBorg build mpv

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘wayland-1.12.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/wayland/default.nix:25 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

'install' finished successfully (1.030s)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0
shrinking /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0/bin/.mpv-wrapped
shrinking /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0/lib/libmpv.so.1.25.0
gzipping man pages under /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0/share/man/
stripping (with flags -S) in /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0/lib  /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0/bin 
patching script interpreter paths in /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0
checking for references to /tmp/nix-build-mpv-0.27.0.drv-0 in /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0...
/nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘wayland-1.12.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/wayland/default.nix:25 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

'install' finished successfully (0.595s)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0
shrinking /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0/lib/libmpv.so.1.25.0
shrinking /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0/bin/.mpv-wrapped
gzipping man pages under /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0/share/man/
stripping (with flags -S) in /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0/lib  /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0/bin 
patching script interpreter paths in /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0
checking for references to /tmp/nix-build-mpv-0.27.0.drv-0 in /nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0...
/nix/store/ipk1w7g2d8hwva8c64bx24sf5bv9xppx-mpv-0.27.0

@andir andir merged commit 4824f56 into NixOS:release-17.09 Feb 7, 2018
@andir andir deleted the 17.09/mpv branch February 7, 2018 09:25
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

checking for references to /build in /nix/store/vy7zjhq087k2gd2s7pdm6hp7j0093rsr-SDL2-2.0.5...
shrinking RPATHs of ELF executables and libraries in /nix/store/213v0myj7y9x25mqcryjm22ylqv128s5-SDL2-2.0.5-dev
stripping (with flags -S) in /nix/store/213v0myj7y9x25mqcryjm22ylqv128s5-SDL2-2.0.5-dev/lib  /nix/store/213v0myj7y9x25mqcryjm22ylqv128s5-SDL2-2.0.5-dev/bin
patching script interpreter paths in /nix/store/213v0myj7y9x25mqcryjm22ylqv128s5-SDL2-2.0.5-dev
/nix/store/213v0myj7y9x25mqcryjm22ylqv128s5-SDL2-2.0.5-dev/bin/sdl2-config: interpreter directive changed from "/bin/sh" to "/nix/store/7b94zsymp6g5rzp2pgwhpkw0idjg52x5-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/213v0myj7y9x25mqcryjm22ylqv128s5-SDL2-2.0.5-dev...
cannot build derivation '/nix/store/3kd5mbvl7wqm60nnak8fq2nb92jm0grj-ffmpeg-3.3.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jxwp7px983pv8ghjip3l9r2midzagymh-youtube-dl-2017.10.20.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/l0wm4afyiwwzzhqskszyz268ddjk6fdd-mpv-0.27.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/l0wm4afyiwwzzhqskszyz268ddjk6fdd-mpv-0.27.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/mdby3d0dxv47qcn97y3zppy8bjb4628y-rubberband-1.8.1/lib/ladspa/ladspa-rubberband.so
shrinking /nix/store/mdby3d0dxv47qcn97y3zppy8bjb4628y-rubberband-1.8.1/lib/vamp/vamp-rubberband.so
shrinking /nix/store/mdby3d0dxv47qcn97y3zppy8bjb4628y-rubberband-1.8.1/bin/rubberband
stripping (with flags -S) in /nix/store/mdby3d0dxv47qcn97y3zppy8bjb4628y-rubberband-1.8.1/lib  /nix/store/mdby3d0dxv47qcn97y3zppy8bjb4628y-rubberband-1.8.1/bin
patching script interpreter paths in /nix/store/mdby3d0dxv47qcn97y3zppy8bjb4628y-rubberband-1.8.1
checking for references to /build in /nix/store/mdby3d0dxv47qcn97y3zppy8bjb4628y-rubberband-1.8.1...
cannot build derivation '/nix/store/3kd5mbvl7wqm60nnak8fq2nb92jm0grj-ffmpeg-3.3.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jxwp7px983pv8ghjip3l9r2midzagymh-youtube-dl-2017.10.20.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/l0wm4afyiwwzzhqskszyz268ddjk6fdd-mpv-0.27.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/l0wm4afyiwwzzhqskszyz268ddjk6fdd-mpv-0.27.0.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @GrahamcOfBorg