Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the coroutine implementations to do a lazy init #3146

Merged
merged 3 commits into from Apr 8, 2019
Merged

Changing the coroutine implementations to do a lazy init #3146

merged 3 commits into from Apr 8, 2019

Conversation

sithhell
Copy link
Member

@sithhell sithhell commented Feb 6, 2018

This changes the context implementations to perform a lazy initialization
of their respective contexts. This potentially leads to less resource usage.

@hkaiser hkaiser added this to the 1.1.0 milestone Feb 6, 2018
@biddisco
Copy link
Contributor

FYI: Rebased onto latest master

hkaiser
hkaiser reviewed Mar 13, 2018
View reviewed changes
src/runtime_impl.cpp Outdated Show resolved Hide resolved
hkaiser
hkaiser reviewed Mar 13, 2018
View reviewed changes
src/runtime_impl.cpp Outdated Show resolved Hide resolved
hkaiser
hkaiser reviewed Mar 13, 2018
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the context implementation that is based on boost::context require changes as well?

@msimberg msimberg mentioned this pull request Mar 16, 2018
Merged
@biddisco biddisco mentioned this pull request Mar 16, 2018
Closed
@msimberg msimberg removed this from the 1.1.0 milestone Mar 22, 2018
@msimberg
Copy link
Contributor

@sithhell Is there anything still missing for this one besides cleanup and rebasing? Or would you like to merge this one only once there is a PR for stack reuse?

@biddisco
Copy link
Contributor

Just bumping this PR. The branch needs to be updated to run with current master.

@biddisco biddisco force-pushed the lazy_thread_init branch 2 times, most recently from 3995e6d to acc2c32 Compare February 5, 2019 21:18
Thomas Heller and others added 3 commits April 7, 2019 12:59
@hkaiser
Changing the coroutine implementations to do a lazy init
0801f1a 
This changes the context implementations to perform a lazy initialization
of their respective contexts. This potentially leads to less resource usage.
@biddisco @hkaiser
fix a typo in lazy_thread_init merge
d96ef4f
@hkaiser
Addressing review comments
ee10d77
@hkaiser
Copy link
Member

hkaiser commented Apr 7, 2019

@msimberg, @sithhell: I have rebased this branch and have addressed the review comments. This should be good to go.

@hkaiser hkaiser merged commit c3d9990 into master Apr 8, 2019
@hkaiser hkaiser deleted the lazy_thread_init branch April 8, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg left review comments

@hkaiser hkaiser hkaiser left review comments

Assignees
No one assigned
Labels
category: threadmanager type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sithhell @biddisco @msimberg @hkaiser