Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lttng-ust: refactor #34661

Closed
wants to merge 1 commit into from
Closed

lttng-ust: refactor #34661

wants to merge 1 commit into from

Conversation

adevress
Copy link
Contributor

@adevress adevress commented Feb 6, 2018 •
edited

Motivation for this change

liburcu appears in the public API of LTTNG: it should be a
propagatedBuildInputs.

This was causing a compilation error with a recent ceph build, depending on LTTNG.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adevress
lttng-ust: refactor
5119b53 
liburcu appears in the public API of LTTNG: it should be a
propagatedBuildInputs.
@adevress adevress mentioned this pull request Feb 6, 2018
Merged
8 tasks
adevress added a commit to adevress/nixpkgs that referenced this pull request Feb 6, 2018
@adevress
ceph: 9.2.0 -> 12.2.2
6beb4da 
- Update Ceph to last version
- Solve vulernatibility problem in the old version
- Patch rocksdb ceph rocksdb API
- Simplify a lot ceph build by switching to CMake

This Pull request require NixOS#34662 and NixOS#34661 to be effective
@adevress
Copy link
Contributor Author

adevress commented Feb 7, 2018

Any comments of a maintainer on that ?

@bjornfor
Copy link
Contributor

bjornfor commented Feb 7, 2018

Based on your commit message, this sounds fine to me.

@bjornfor
Copy link
Contributor

bjornfor commented Feb 7, 2018

Applied to master (52f6310). Thanks!

@bjornfor bjornfor closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adevress @bjornfor @GrahamcOfBorg