Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move yield_while out of detail namespace and into own file #3147

Merged
merged 1 commit into from Feb 8, 2018
Merged

Move yield_while out of detail namespace and into own file #3147

merged 1 commit into from Feb 8, 2018

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Feb 6, 2018

Proposed Changes

  • Move yield_while from yield_k.hpp in the detail namespace to its own file not in the detail namespace
  • Make nullptr the default value for the thread_name parameter in yield_while

@hkaiser hkaiser added this to the 1.1.0 milestone Feb 6, 2018
hkaiser
hkaiser approved these changes Feb 6, 2018
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit c807a4e into STEllAR-GROUP:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: core category: threadmanager type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msimberg @hkaiser