Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql: 9.3.20 -> 9.3.22, 9.4.15 -> 9.4.17, 9.5.10 -> 9.5.12, 9.6.6 -> 9.6.8, 10.1 -> 10.3 #36386

Closed
wants to merge 1 commit into from
Closed

postgresql: 9.3.20 -> 9.3.22, 9.4.15 -> 9.4.17, 9.5.10 -> 9.5.12, 9.6.6 -> 9.6.8, 10.1 -> 10.3 #36386

wants to merge 1 commit into from

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Mar 6, 2018

for CVE-2018-1058: Uncontrolled search path element in
pg_dump and other client applications

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
postgresql: 9.3.20 -> 9.3.22, 9.4.15 -> 9.4.17, 9.5.10 -> 9.5.12, 9.6…
d5cdddd 
….6 -> 9.6.8, 10.1 -> 10.3

for CVE-2018-1058: Uncontrolled search path element in
pg_dump and other client applications
@grahamc
Copy link
Member Author

grahamc commented Mar 6, 2018

@GrahamcOfBorg build postgresql93 postgresql94 postgresql95 postgresql96 postgresql100
@GrahamcOfBorg test postgresql

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/w3a88zk1npggf35vwp260xb97hv68cml-postgresql-9.3.22/lib/pgxs/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/w3a88zk1npggf35vwp260xb97hv68cml-postgresql-9.3.22/lib/pgxs/config/missing: interpreter directive changed from " /bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7m7krf3yh0fkixxw4ar38ycfl31086l7-postgresql-9.3.22-lib/lib
patching script interpreter paths in /nix/store/7m7krf3yh0fkixxw4ar38ycfl31086l7-postgresql-9.3.22-lib
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/r1g40s48sr9gajqyhdhaj80z3wp42gly-postgresql-9.3.22-doc
gzipping man pages under /nix/store/rzdrgnj2dg7zy1fgmxf8ccckqayqnhja-postgresql-9.3.22-man/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/rzdrgnj2dg7zy1fgmxf8ccckqayqnhja-postgresql-9.3.22-man

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/na2jlagf0vw01d0n1gibxi3dq4qf634v-postgresql-9.6.8-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc
checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man
gzipping man pages under /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man
checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these derivations will be built:
  /nix/store/4vs3yn5d398r88y0qjfh1gvpw9z9cd2z-postgresql-9.6.8.drv
waiting for locks or build slots...
/nix/store/2kdrj5brs930az13zgb92q0c21q6cr5a-postgresql-9.6.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

checking for references to /build in /nix/store/gmbqlbypg8mmcnn06xi50ckly2gifsj1-postgresql-9.6.8-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/0yi9hncqfl8qnjwjf5byx59b5mrvkkhm-postgresql-9.6.8-doc
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/0yi9hncqfl8qnjwjf5byx59b5mrvkkhm-postgresql-9.6.8-doc
checking for references to /build in /nix/store/0yi9hncqfl8qnjwjf5byx59b5mrvkkhm-postgresql-9.6.8-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/r4b1kb2wj71pih2mdfpjnr8pzrp0yhmm-postgresql-9.6.8-man
gzipping man pages under /nix/store/r4b1kb2wj71pih2mdfpjnr8pzrp0yhmm-postgresql-9.6.8-man/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/r4b1kb2wj71pih2mdfpjnr8pzrp0yhmm-postgresql-9.6.8-man
checking for references to /build in /nix/store/r4b1kb2wj71pih2mdfpjnr8pzrp0yhmm-postgresql-9.6.8-man...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/x0wnyfpz1lngk5mshm10rkdqi4gcr0cr-postgresql-9.6.8/lib/pgxs/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/x0wnyfpz1lngk5mshm10rkdqi4gcr0cr-postgresql-9.6.8/lib/pgxs/config/missing: interpreter directive changed from " /bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/mqcr7y9vwaivs2dm04k6i29ccxn8k09c-postgresql-9.6.8-lib/lib
patching script interpreter paths in /nix/store/mqcr7y9vwaivs2dm04k6i29ccxn8k09c-postgresql-9.6.8-lib
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/3z608gnglf82smcwqvdblfjpisv9raga-postgresql-9.6.8-doc
gzipping man pages under /nix/store/jrqrgji7x9vxlb5sk5m3fys5904bx7lz-postgresql-9.6.8-man/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/jrqrgji7x9vxlb5sk5m3fys5904bx7lz-postgresql-9.6.8-man

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/na2jlagf0vw01d0n1gibxi3dq4qf634v-postgresql-9.6.8-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc
checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man
gzipping man pages under /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man
checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man...

@grahamc
Copy link
Member Author

grahamc commented Mar 6, 2018

@GrahamcOfBorg test postgresql

Let's try this again ...

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

GC Warning: Failed to expand heap by 4294967296 bytes
Can't start up: not enough memory

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

@grahamc
Copy link
Member Author

grahamc commented Mar 6, 2018

:(

@grahamc
Copy link
Member Author

grahamc commented Mar 6, 2018

I can try that tonight!

@domenkozar
Copy link
Member

@grahamc did you manage to bump GC heap?

@infinisil
Copy link
Member

All of these have been updated by @thoughtpolice in 7e21fd7 and parents now

@infinisil infinisil closed this Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grahamc @GrahamcOfBorg @domenkozar @infinisil