Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conky: provide option to build with pulseaudio support #36387

Merged
merged 1 commit into from Mar 18, 2018

Conversation

nioncode
Copy link
Member

@nioncode nioncode commented Mar 6, 2018

Motivation for this change

Conky has variables that allow to access PulseAudio specific values (like volume), which are not included by default.
When declaring config.pulseaudio, the module will now include PulseAudio support automatically.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nioncode
Copy link
Member Author

nioncode commented Mar 7, 2018

@GrahamcOfBorg build conky
/cc @dguibert

@jtojnar jtojnar merged commit d0a9dcb into NixOS:master Mar 18, 2018
@nioncode nioncode deleted the conky-pulseaudio branch March 18, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants