New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix File.extname to handle path with dot in directory name #5782

Closed

straight-shoota wants to merge 1 commit into crystal-lang:master from straight-shoota:jm/fix/file-extname

Member

straight-shoota commented Mar 6, 2018

Fixes #5780


          Fix File.extname to handle path with dot in directory name

48b62e6

RX14 approved these changes

View reviewed changes

Sija mentioned this pull request

Fixed File.extname edge case for '.' in path with no extension #5790

Merged

Member Author

straight-shoota commented Mar 8, 2018

Closing in favour of #5790 which is a better solution as it doesn't allocate an additional string and is more performant.

straight-shoota closed this

straight-shoota deleted the jm/fix/file-extname branch

November 18, 2021 17:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment