Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages vue-cli: init at 2.9.3 #36391

Merged
merged 6 commits into from Apr 1, 2018
Merged

nodePackages vue-cli: init at 2.9.3 #36391

merged 6 commits into from Apr 1, 2018

Conversation

tiramiseb
Copy link
Contributor

@tiramiseb tiramiseb commented Mar 6, 2018 •
edited

Motivation for this change

Being able to use install vue-cli as a nix package...

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I have done this change according to https://nixos.org/nixpkgs/manual/#node.js-packages. Multiple other packages versions would be changed too, I don't know if it is okay to do it like that.

I could instead create a regular package like the one for yarn (https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/yarn/default.nix) and, if it is the right way to do it, I should be able to do so. However, I don't even understand why yarn is a separate package and not a nodePackage...

@tiramiseb tiramiseb changed the title nodePackages vue-cli and @vue/cli: init at 2.9.3 and 3.0.0-beta5 nodePackages vue-cli and @vue/cli: init at 2.9.3 and 3.0.0-beta.6 Mar 19, 2018
@tiramiseb tiramiseb changed the title nodePackages vue-cli and @vue/cli: init at 2.9.3 and 3.0.0-beta.6 nodePackages vue-cli: init at 2.9.3 Mar 31, 2018
@zimbatm
Copy link
Member

zimbatm commented Apr 1, 2018

@GrahamcOfBorg build nodePackages.vue-cli

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nodePackages.vue-cli

Partial log (click to expand)

/nix/store/fl5yjmxq80jm1sz2f1r65gz2pa0fa4b8-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/esprima/bin/esvalidate.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/5n3na4aci7bk3j25jjv11inp24af2ri6-nodejs-6.14.1/bin/node"
/nix/store/fl5yjmxq80jm1sz2f1r65gz2pa0fa4b8-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/delayed-call.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/fl5yjmxq80jm1sz2f1r65gz2pa0fa4b8-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/delayed-require.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/fl5yjmxq80jm1sz2f1r65gz2pa0fa4b8-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/difference.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/fl5yjmxq80jm1sz2f1r65gz2pa0fa4b8-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/initial-value.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/fl5yjmxq80jm1sz2f1r65gz2pa0fa4b8-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/uglify-js/bin/uglifyjs: interpreter directive changed from " /usr/bin/env node" to "/nix/store/5n3na4aci7bk3j25jjv11inp24af2ri6-nodejs-6.14.1/bin/node"
/nix/store/fl5yjmxq80jm1sz2f1r65gz2pa0fa4b8-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/win-fork/bin/win-line-endings: interpreter directive changed from "/usr/bin/env node" to "/nix/store/5n3na4aci7bk3j25jjv11inp24af2ri6-nodejs-6.14.1/bin/node"
/nix/store/fl5yjmxq80jm1sz2f1r65gz2pa0fa4b8-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/win-fork/bin/win-spawn: interpreter directive changed from "/usr/bin/env node" to "/nix/store/5n3na4aci7bk3j25jjv11inp24af2ri6-nodejs-6.14.1/bin/node"
checking for references to /build in /nix/store/fl5yjmxq80jm1sz2f1r65gz2pa0fa4b8-node-vue-cli-2.9.3...
/nix/store/fl5yjmxq80jm1sz2f1r65gz2pa0fa4b8-node-vue-cli-2.9.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nodePackages.vue-cli

Partial log (click to expand)

/nix/store/9pxn2cx1dxp7cb4snm1fs7s1frzh45hd-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/esprima/bin/esparse.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/9pxn2cx1dxp7cb4snm1fs7s1frzh45hd-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/esprima/bin/esvalidate.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/9pxn2cx1dxp7cb4snm1fs7s1frzh45hd-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/delayed-call.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/9pxn2cx1dxp7cb4snm1fs7s1frzh45hd-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/delayed-require.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/9pxn2cx1dxp7cb4snm1fs7s1frzh45hd-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/difference.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/9pxn2cx1dxp7cb4snm1fs7s1frzh45hd-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/initial-value.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/9pxn2cx1dxp7cb4snm1fs7s1frzh45hd-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/uglify-js/bin/uglifyjs: interpreter directive changed from " /usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/9pxn2cx1dxp7cb4snm1fs7s1frzh45hd-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/win-fork/bin/win-line-endings: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/9pxn2cx1dxp7cb4snm1fs7s1frzh45hd-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/win-fork/bin/win-spawn: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/9pxn2cx1dxp7cb4snm1fs7s1frzh45hd-node-vue-cli-2.9.3

@zimbatm zimbatm merged commit e8ad790 into NixOS:master Apr 1, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodePackages.vue-cli

Partial log (click to expand)

/nix/store/pc0k0vfxwfw67gvnmrl6y2ggzi4pqqam-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/win-fork/bin/win-line-endings: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yl24fbb6aaqgzikrpfgdcjn488dl9wy0-nodejs-6.14.1/bin/node"
/nix/store/pc0k0vfxwfw67gvnmrl6y2ggzi4pqqam-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/uglify-js/bin/uglifyjs: interpreter directive changed from " /usr/bin/env node" to "/nix/store/yl24fbb6aaqgzikrpfgdcjn488dl9wy0-nodejs-6.14.1/bin/node"
/nix/store/pc0k0vfxwfw67gvnmrl6y2ggzi4pqqam-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/initial-value.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/pc0k0vfxwfw67gvnmrl6y2ggzi4pqqam-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/difference.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/pc0k0vfxwfw67gvnmrl6y2ggzi4pqqam-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/delayed-require.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/pc0k0vfxwfw67gvnmrl6y2ggzi4pqqam-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/performance-now/test/scripts/delayed-call.coffee: interpreter directive changed from "/usr/bin/env ./node_modules/.bin/coffee" to "./node_modules/.bin/coffee"
/nix/store/pc0k0vfxwfw67gvnmrl6y2ggzi4pqqam-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/esprima/bin/esvalidate.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yl24fbb6aaqgzikrpfgdcjn488dl9wy0-nodejs-6.14.1/bin/node"
/nix/store/pc0k0vfxwfw67gvnmrl6y2ggzi4pqqam-node-vue-cli-2.9.3/lib/node_modules/vue-cli/node_modules/esprima/bin/esparse.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yl24fbb6aaqgzikrpfgdcjn488dl9wy0-nodejs-6.14.1/bin/node"
checking for references to /build in /nix/store/pc0k0vfxwfw67gvnmrl6y2ggzi4pqqam-node-vue-cli-2.9.3...
/nix/store/pc0k0vfxwfw67gvnmrl6y2ggzi4pqqam-node-vue-cli-2.9.3

@tiramiseb tiramiseb deleted the vue-cli branch April 1, 2018 12:16
abbradar pushed a commit that referenced this pull request Apr 2, 2018
@tiramiseb @abbradar
nodePackages vue-cli: init at 2.9.3 (#36391)
5bcdc86 
(cherry picked from commit e8ad790)
abbradar pushed a commit to abbradar/nixpkgs that referenced this pull request Apr 11, 2018
@tiramiseb @abbradar
nodePackages vue-cli: init at 2.9.3 (NixOS#36391)
148ed6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiramiseb @zimbatm @GrahamcOfBorg