x86_64-musl bootstrap: refresh bootstrap tools package #36384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compressed: 28M -> 20M uncompressed: 201M -> 119M Built using: NixOS@94f3dc4 cc NixOS#36383
|
@dtzWill still confident to merge this? :) |
|
@dtzWill ping? |
|
Oh, this doesn't actually include the commits over in #36383 -- they were just what I used for generating the tarballs. Awesome, this means resolving conflicts over there won't require regenerating and perma-hosting more tarballs for no reason :P. |
|
I tested this rather thoroughly previously-- it's conceivable the new bootstrap tarballs are newly incompatible in some subtle way introduced since then, but I think that's unlikely and especially unlikely to be due to tarball being wrong. Hopefully I don't eat those words ;). Will give this at least a bit of new testing but otherwise I say merge! |
|
@GrahamcOfBorg build pkgsMusl.bash pkgsMusl.lzip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Native"-built: Seems to work better in non-sandboxed builds[1]
Symlinks preserved: (#36364)
Significantly smaller: (#36383)
Resulting size is about the same as what is currently
used in nixpkgs master (compressed), but smaller
(161M -> 101M).
Most notable difference is that this uses gcc7.
[1] such as often used in docker containers.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)