Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sdl2 and friends update #36389

Merged
merged 3 commits into from Mar 6, 2018
Merged

Sdl2 and friends update #36389

merged 3 commits into from Mar 6, 2018

Conversation

cpages
Copy link
Contributor

@cpages cpages commented Mar 6, 2018

Motivation for this change

Many bugfixes and security issues fixed

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@cpages
SDL2: 2.0.7 -> 2.0.8
344bc9c
@cpages
SDL2_image: 2.0.2 -> 2.0.3
231f213
@cpages
SDL2_gfx: 1.0.1 -> 1.0.4
08049f4 
Setting myself as maintainer. It was only set to bjg due to an original
copy-paste.
@7c6f434c
Copy link
Member

7c6f434c commented Mar 6, 2018

Let's see what is the rebuild size… maybe I should merge it simultaneously with #36377 — security updates sound like a good reason to touch SDL2 in master directly

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0sg821l7y985j22zbpd49p13zxdyal3m-SDL2_image-2.0.3
shrinking /nix/store/0sg821l7y985j22zbpd49p13zxdyal3m-SDL2_image-2.0.3/lib/libSDL2_image-2.0.so.0.2.1
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/0sg821l7y985j22zbpd49p13zxdyal3m-SDL2_image-2.0.3/lib 
patching script interpreter paths in /nix/store/0sg821l7y985j22zbpd49p13zxdyal3m-SDL2_image-2.0.3
checking for references to /tmp/nix-build-SDL2_image-2.0.3.drv-0 in /nix/store/0sg821l7y985j22zbpd49p13zxdyal3m-SDL2_image-2.0.3...
/nix/store/kn821j0j85zncz1m4q7qwxb1wwhvaxb4-SDL2-2.0.8
/nix/store/rpr53a3mqpqbzyn1ck45d66iimc6vv6b-SDL2_gfx-1.0.4
/nix/store/0sg821l7y985j22zbpd49p13zxdyal3m-SDL2_image-2.0.3

@7c6f434c
Copy link
Member

7c6f434c commented Mar 6, 2018

(for some minor kind of record: SDL2_gfx SourceForge page links to http://ferzkopp.net/ for the «project site»)

@7c6f434c 7c6f434c merged commit c8664a2 into NixOS:master Mar 6, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ri2bv046qm9db08yw4b5vdjh5prx9025-SDL2_gfx-1.0.4
shrinking /nix/store/ri2bv046qm9db08yw4b5vdjh5prx9025-SDL2_gfx-1.0.4/lib/libSDL2_gfx-1.0.so.0.0.2
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ri2bv046qm9db08yw4b5vdjh5prx9025-SDL2_gfx-1.0.4/lib
patching script interpreter paths in /nix/store/ri2bv046qm9db08yw4b5vdjh5prx9025-SDL2_gfx-1.0.4
checking for references to /build in /nix/store/ri2bv046qm9db08yw4b5vdjh5prx9025-SDL2_gfx-1.0.4...
/nix/store/cjkg0shp0qgmz22ln8y7qc6wyk903dq8-SDL2-2.0.8
/nix/store/ri2bv046qm9db08yw4b5vdjh5prx9025-SDL2_gfx-1.0.4
/nix/store/31cl8hzck2s7nkp05sb3zjjimkzyh4p8-SDL2_image-2.0.3

@7c6f434c
Copy link
Member

7c6f434c commented Mar 6, 2018

All the Java/FFmpeg/etc. rebuild horrors are caused just by SDL2 per se.

@oxij oxij mentioned this pull request Mar 6, 2018
Merged
5 tasks
@cpages cpages deleted the sdl2 branch March 6, 2018 20:48
vcunat pushed a commit that referenced this pull request Mar 7, 2018
@7c6f434c @vcunat
Merge pull request #36389 from cpages/sdl2
7b987e2 
Sdl2 and friends update

(cherry picked from commit c8664a2)
Security fixes inside, reportedly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpages @7c6f434c @GrahamcOfBorg