-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xen: 4.8.2 -> 4.8.3 #36388
xen: 4.8.2 -> 4.8.3 #36388
Conversation
@GrahamcOfBorg build xen |
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
@7c6f434c please build xen_4_8 xen_4_8-light xen_4_8-slim |
@GrahamcOfBorg build xen_4_8 xen_4_8-light xen_4_8-slim |
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
I looked at the build log and I don't understand what has failed. @oxij — do you see anything interesting in the log? |
Don't understand this either. Builds on my machine. |
I looked at the build log and I don't understand what has failed. @oxij — do you see anything interesting in the log?
I have the same problem. I have no idea what could have broke with just this change.
Maybe try building them one by one? I have a feeling that there's an error hidden somewhere between the three of the rebuilds.
|
@GrahamcOfBorg build xen_4_8 @GrahamcOfBorg build xen_4_8-light @GrahamcOfBorg build xen_4_8-slim |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
ok, guess i can fix that :-) |
Weird. Looks like |
should build now |
@xeji are you sure it doesn't change every time? |
don't think so. I just started the build with a dummy hash and got exactly the same hash as ofborg in the error log. neither the git revision nor the submodule commits have changed recently. If this was a general problem, we would have encountered it many times already when building xen. I thik it's just nix-prefetch-git. |
@GrahamcOfBorg build xen_4_8 xen_4_8-light xen_4_8-slim |
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
I think the problem is that `qemu-xen`'s `fetchgit` expression depends on branch/tag instead of revision hash and xen devs move it from time to time. If you look at the log you'll notice that I had to fix that at least once before.
I'm unsure whenever this is a feature or a bug. If we change that tag to revision hash it would become deterministic. But if we leave it as is, then I would notice that they patched `qemu-xen` with some new XSA on the next mass rebuild when updating a single machine I have that uses `qemu-xen` instead of the upstream qemu :)
Feel free to do either. If you leave it as is I'll switch it to revision hash after I subscribe to XSA's :)
|
Thanks, switching to revision hash is a good idea. l would leave this as is for now and clean this up next time. |
Motivation for this change
minor bugfix release
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)/cc @oxij