nixos/acpid: add option to log events #35026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lheckemann
reviewed
Feb 16, 2018
| @@ -142,7 +148,7 @@ in | |||
| ConditionPathExists = [ "/proc/acpi" ]; | |||
| }; | |||
|
|
|||
| script = "acpid --confdir ${acpiConfDir}"; | |||
| script = "acpid ${if config.services.acpid.logEvents then "--logevents" else ""} --confdir ${acpiConfDir}"; | |||
alesya-h
force-pushed
the
acpid_log_events
branch
from
4146180
to
444cdf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
acpidhas a--logeventsflag to log all acpi events, which is useful to find an event you are interested in, or when debug certain issues. This change exposes that flag as a nixos option.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)