New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-pysqlite: fix darwin build #35021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python: housekeeping
…os-in-openssh openssh: Document default Kerberos support
busybox: bump copybuf, disable utmp/wtmp when not supported (musl)
pythonPackages.testtools: clean up dependencies
Update LLVM default 4 -> 5
Note this doesn't actually provide musl support yet, just improves our "system" code to understand musl-based triples and non-glibc linux configurations.
gnu "abi" doesn't mean glibc (mingw, apparently).
lib/systems: musl "ABI"s, examples
Co-Authored-By: Florian Klink <flokli@flokli.de> Co-Authored-By: Andreas Rammhold <andreas@rammhold.de>
Conflicts: pkgs/development/libraries/libclc/default.nix pkgs/top-level/all-packages.nix
Note that currently getent is explicitly taken from "glibc.bin", regardless of build configuration which this preserves for now. (on non-musl anyway)
reviewer feedback + minor other things I noticed while revisiting.
Workaround for building "from" the bfd directory but needing to update files a level above. This needs to be done *after* autoreconf since autoreconf will replace these itself, apparently.
Fixes cross build by removing false dependency. If this is needed again, be careful about *which* "groff" is needed. (which in terms of build vs host)
musl-cross, native-musl, cross fixes, oh my!
I also saw NixOS#33946, though I'm not sure what to make of it...
There's also 4.0.0, but I'd leave that for later.
This used to be the case before commit 531e4b8 which seems to have dropped it by accident. Removes one unnecessary build of pkgconfig during stdenv bootstrapping.
It's not actually needed, and AFAICT has never been. Or at least Buildroot can build kernel headers as old as 3.2 without running the config phase. While at it, set ARCH unconditionally.
Nothing actually needs this.
After the systemd 237 upgrade, radvd wouldn't start anymore because the PID file cannot be written. It seems that directories in /run has to be explicitely defined as RuntimeDirectory now. The PID file isn't needed due to systemd, though, so it was removed along with forking and loggia via syslog. This fixes the ipv6 NixOS test.
vcunat
added a commit
that referenced
this pull request
Feb 16, 2018
It's the last staging commit (mostly) built on Hydra, and a minimal fix for Darwin regression in pysqlite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)NixOSnix-shell -p nox --run "nox-review wip"
./result/bin/
)