Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildkite-agent: 2.1.13 -> 2.6.9 #35034

Closed
wants to merge 3 commits into from
Closed

buildkite-agent: 2.1.13 -> 2.6.9 #35034

wants to merge 3 commits into from

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Feb 16, 2018

Motivation for this change

Newer upstream version which fixes bugs.

See also: #35033

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rvl rvl changed the title Buildkite agent update buildkite-agent: 2.1.13 -> 2.6.9 Feb 16, 2018
@domenkozar
Copy link
Member

@GrahamcOfBorg build buildkite-agent

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

error: while evaluating the attribute 'buildInputs' of the derivation 'buildkite-agent-2.6.9' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute 'GOARCH' of the derivation 'go-1.9.2' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:98:11:
Unsupported system

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/vzbs0in1zvqkg3pm8vslf9ggvrg2zjg9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/command.sample: interpreter directive changed from "/bin/bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/vzbs0in1zvqkg3pm8vslf9ggvrg2zjg9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/checkout.sample: interpreter directive changed from "/bin/bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/vzbs0in1zvqkg3pm8vslf9ggvrg2zjg9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/pre-artifact.sample: interpreter directive changed from "/bin/bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/vzbs0in1zvqkg3pm8vslf9ggvrg2zjg9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/post-checkout.sample: interpreter directive changed from "/bin/bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/vzbs0in1zvqkg3pm8vslf9ggvrg2zjg9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/pre-exit.sample: interpreter directive changed from "/bin/bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/vzbs0in1zvqkg3pm8vslf9ggvrg2zjg9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/post-artifact.sample: interpreter directive changed from "/bin/bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/vzbs0in1zvqkg3pm8vslf9ggvrg2zjg9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/pre-checkout.sample: interpreter directive changed from "/bin/bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/vzbs0in1zvqkg3pm8vslf9ggvrg2zjg9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/environment.sample: interpreter directive changed from "/bin/bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-buildkite-agent-2.6.9.drv-0 in /nix/store/vzbs0in1zvqkg3pm8vslf9ggvrg2zjg9-buildkite-agent-2.6.9...
/nix/store/b44063nfmyjj6yx8nl4zy0xqj5pgsq1k-buildkite-agent-2.6.9-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/yqkjwjwpqn9nvr966lp2pi4jbga853mb-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/scripts/utils/publish-debian-package.sh: interpreter directive changed from "/bin/bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/yqkjwjwpqn9nvr966lp2pi4jbga853mb-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/0.2/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/yqkjwjwpqn9nvr966lp2pi4jbga853mb-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/1.0-beta.1-6/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/yqkjwjwpqn9nvr966lp2pi4jbga853mb-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/yqkjwjwpqn9nvr966lp2pi4jbga853mb-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/github.com/kr/pty/mktypes.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/yqkjwjwpqn9nvr966lp2pi4jbga853mb-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/yqkjwjwpqn9nvr966lp2pi4jbga853mb-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/yqkjwjwpqn9nvr966lp2pi4jbga853mb-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/yqkjwjwpqn9nvr966lp2pi4jbga853mb-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/l7wri8vqcyg6i5gk119505zf97wrpis0-buildkite-agent-2.6.9-bin

@rvl rvl changed the title buildkite-agent: 2.1.13 -> 2.6.9 [WIP] buildkite-agent: 2.1.13 -> 2.6.9 Feb 17, 2018
@rvl
Copy link
Contributor Author

rvl commented Feb 17, 2018

WIP, going to check a few things.

@rvl
buildkite-agent service: remove obsolete config option
2b866b4 
Newer versions of buildkite-agent can find the bootstrap script
themselves.
@rvl rvl changed the title [WIP] buildkite-agent: 2.1.13 -> 2.6.9 buildkite-agent: 2.1.13 -> 2.6.9 Feb 18, 2018
@rvl
Copy link
Contributor Author

rvl commented Feb 18, 2018

I decided that these changes are not suitable for the 17.09 branch. 😊

@rvl rvl closed this Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvl @domenkozar @GrahamcOfBorg