Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildkite-agent: 2.6.6 -> 2.6.9 #35033

Merged
merged 2 commits into from Feb 17, 2018
Merged

buildkite-agent: 2.6.6 -> 2.6.9 #35033

merged 2 commits into from Feb 17, 2018

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Feb 16, 2018

Motivation for this change

Various upstream bug fixes.

https://github.com/buildkite/agent/releases/tag/v2.6.7
https://github.com/buildkite/agent/releases/tag/v2.6.8
https://github.com/buildkite/agent/releases/tag/v2.6.9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rvl rvl mentioned this pull request Feb 16, 2018
Closed
8 tasks
@domenkozar
Copy link
Member

@GrahamcOfBorg build buildkite-agent

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/k72r4m0waz14jk00gbxblkbqzi8fhzyx-buildkite-agent-2.6.9-bin
shrinking /nix/store/k72r4m0waz14jk00gbxblkbqzi8fhzyx-buildkite-agent-2.6.9-bin/bin/.buildkite-agent-wrapped
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/k72r4m0waz14jk00gbxblkbqzi8fhzyx-buildkite-agent-2.6.9-bin/libexec  /nix/store/k72r4m0waz14jk00gbxblkbqzi8fhzyx-buildkite-agent-2.6.9-bin/bin
patching script interpreter paths in /nix/store/k72r4m0waz14jk00gbxblkbqzi8fhzyx-buildkite-agent-2.6.9-bin
checking for references to /build in /nix/store/k72r4m0waz14jk00gbxblkbqzi8fhzyx-buildkite-agent-2.6.9-bin...
wrapper script /nix/store/k72r4m0waz14jk00gbxblkbqzi8fhzyx-buildkite-agent-2.6.9-bin/bin/buildkite-agent contains a forbidden reference to /build
builder for '/nix/store/45yf2sj3vzzd323brq14hqcfrnv69b4g-buildkite-agent-2.6.9.drv' failed with exit code 1
error: build of '/nix/store/45yf2sj3vzzd323brq14hqcfrnv69b4g-buildkite-agent-2.6.9.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gbjf94zhl8ldza3fij9cj0m723n08gdn-buildkite-agent-2.6.9-bin
shrinking /nix/store/gbjf94zhl8ldza3fij9cj0m723n08gdn-buildkite-agent-2.6.9-bin/bin/.buildkite-agent-wrapped
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/gbjf94zhl8ldza3fij9cj0m723n08gdn-buildkite-agent-2.6.9-bin/libexec  /nix/store/gbjf94zhl8ldza3fij9cj0m723n08gdn-buildkite-agent-2.6.9-bin/bin
patching script interpreter paths in /nix/store/gbjf94zhl8ldza3fij9cj0m723n08gdn-buildkite-agent-2.6.9-bin
checking for references to /build in /nix/store/gbjf94zhl8ldza3fij9cj0m723n08gdn-buildkite-agent-2.6.9-bin...
wrapper script /nix/store/gbjf94zhl8ldza3fij9cj0m723n08gdn-buildkite-agent-2.6.9-bin/bin/buildkite-agent contains a forbidden reference to /build
builder for '/nix/store/2cx91saqhij3h3ig50drvvhm4v0sw5zr-buildkite-agent-2.6.9.drv' failed with exit code 1
error: build of '/nix/store/2cx91saqhij3h3ig50drvvhm4v0sw5zr-buildkite-agent-2.6.9.drv' failed

@domenkozar
Copy link
Member

cc @rvl

@rvl
Copy link
Contributor Author

rvl commented Feb 16, 2018

On my machine:

checking for references to /tmp/nix-build-buildkite-agent-2.6.9.drv-0 in /nix/store/9pzysxn3jzrqj8gnjbrbvh3v6i2m79jk-buildkite-agent-2.6.9...

I think it might be finding /build due to the name of this package.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/l5a2qvkx78rpfl24p350x9fil65scyh9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/scripts/utils/publish-debian-package.sh: interpreter directive changed from "/bin/bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/l5a2qvkx78rpfl24p350x9fil65scyh9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/0.2/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/l5a2qvkx78rpfl24p350x9fil65scyh9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/1.0-beta.1-6/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/l5a2qvkx78rpfl24p350x9fil65scyh9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/l5a2qvkx78rpfl24p350x9fil65scyh9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/github.com/kr/pty/mktypes.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/l5a2qvkx78rpfl24p350x9fil65scyh9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/l5a2qvkx78rpfl24p350x9fil65scyh9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/l5a2qvkx78rpfl24p350x9fil65scyh9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/l5a2qvkx78rpfl24p350x9fil65scyh9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/m60222dzm40h03n3jmydrzqj1f5wv2ii-buildkite-agent-2.6.9-bin

@rvl
Copy link
Contributor Author

rvl commented Feb 17, 2018

Thanks @zimbatm

@zimbatm
Copy link
Member

zimbatm commented Feb 17, 2018

@GrahamcOfBorg build buildkite-agent

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/1zg8z695wb5g1zjdpbjwg04l62p8s0y9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/scripts/utils/publish-debian-package.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/1zg8z695wb5g1zjdpbjwg04l62p8s0y9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/0.2/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/1zg8z695wb5g1zjdpbjwg04l62p8s0y9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/1.0-beta.1-6/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/1zg8z695wb5g1zjdpbjwg04l62p8s0y9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/1zg8z695wb5g1zjdpbjwg04l62p8s0y9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/github.com/kr/pty/mktypes.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/1zg8z695wb5g1zjdpbjwg04l62p8s0y9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/1zg8z695wb5g1zjdpbjwg04l62p8s0y9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/1zg8z695wb5g1zjdpbjwg04l62p8s0y9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/1zg8z695wb5g1zjdpbjwg04l62p8s0y9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/1m5iy7yhnl69prz4kfqz96819xm8g0z0-buildkite-agent-2.6.9-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/admhlpzq990wjhviv605libbpz9macz9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/scripts/utils/publish-debian-package.sh: interpreter directive changed from "/bin/bash" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash"
/nix/store/admhlpzq990wjhviv605libbpz9macz9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/0.2/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash"
/nix/store/admhlpzq990wjhviv605libbpz9macz9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/1.0-beta.1-6/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash"
/nix/store/admhlpzq990wjhviv605libbpz9macz9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash"
/nix/store/admhlpzq990wjhviv605libbpz9macz9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/github.com/kr/pty/mktypes.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash"
/nix/store/admhlpzq990wjhviv605libbpz9macz9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash"
/nix/store/admhlpzq990wjhviv605libbpz9macz9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash"
/nix/store/admhlpzq990wjhviv605libbpz9macz9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash"
/nix/store/admhlpzq990wjhviv605libbpz9macz9-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/bash"
/nix/store/3jm8wxg7yyncf2l7c7aw4v31jr1vcaxj-buildkite-agent-2.6.9-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/zmns68wcv616y01i82pciw5s71s53fmn-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/scripts/utils/publish-debian-package.sh: interpreter directive changed from "/bin/bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/zmns68wcv616y01i82pciw5s71s53fmn-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/0.2/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/zmns68wcv616y01i82pciw5s71s53fmn-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/1.0-beta.1-6/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/zmns68wcv616y01i82pciw5s71s53fmn-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/templates/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/zmns68wcv616y01i82pciw5s71s53fmn-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/github.com/kr/pty/mktypes.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/zmns68wcv616y01i82pciw5s71s53fmn-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/zmns68wcv616y01i82pciw5s71s53fmn-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/zmns68wcv616y01i82pciw5s71s53fmn-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/zmns68wcv616y01i82pciw5s71s53fmn-buildkite-agent-2.6.9/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash"
/nix/store/zqvfrm30l7sn5vrvlw8m5f5g979p1bn3-buildkite-agent-2.6.9-bin

@zimbatm zimbatm merged commit 34e6226 into NixOS:master Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvl @domenkozar @GrahamcOfBorg @zimbatm