Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pkgconfig: 1.1.0 -> 1.3.1 #36439

Closed
wants to merge 1 commit into from
Closed

pythonPackages.pkgconfig: 1.1.0 -> 1.3.1 #36439

wants to merge 1 commit into from

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 7, 2018 •
edited

Motivation for this change

pkgconfig was outdated

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner March 7, 2018 18:32
@timokau
Copy link
Member Author

timokau commented Mar 7, 2018

This probably shouldn't be merged before I nox-reviewed it

@jfrankenau
Copy link
Member

Duplicate here, see #36434.

@timokau timokau closed this Mar 7, 2018
@timokau
Copy link
Member Author

timokau commented Mar 7, 2018

What a coincidence that nobody updated it since 1.1 from 2003 and now theres two updates on the same day 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @jfrankenau @GrahamcOfBorg