Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wyrd: fix build #36433

Closed
wants to merge 1 commit into from
Closed

wyrd: fix build #36433

wants to merge 1 commit into from

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 7, 2018

Motivation for this change

wyrd has been broken since 3d24ae9. This fix is similar to 8afcfb2.

This should also fix the build on non-gcc stdenvs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

mv //nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6/bin/wyrd.opt //nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6/bin/wyrd
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6
shrinking /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6/bin/wyrd
gzipping man pages under /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6/bin 
patching script interpreter paths in /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6
checking for references to /tmp/nix-build-wyrd-1.4.6.drv-0 in /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6...
/nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

mv //nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6/bin/wyrd.opt //nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6/bin/wyrd
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6
shrinking /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6/bin/wyrd
gzipping man pages under /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6/bin
patching script interpreter paths in /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6
checking for references to /build in /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6...
/nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6

@vbgl vbgl mentioned this pull request Mar 8, 2018
Merged
8 tasks
@dtzWill
Copy link
Member

dtzWill commented Mar 8, 2018

Committed in 1d4bbef, picked to 18.03 in bd6d607 .

@dtzWill dtzWill closed this Mar 8, 2018
@vbgl vbgl deleted the wyrd branch September 13, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: bug 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @GrahamcOfBorg @dtzWill