Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

skypeforlinux: 8.16.0.4 -> 8.17.0.2 #36446

Closed
wants to merge 1 commit into from

Conversation

svsdep
Copy link
Contributor

@svsdep svsdep commented Mar 7, 2018

Motivation for this change

Just another regular update. Getting rid of annoying "Your Skype is outdated" notification 馃槃

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@svsdep
Copy link
Contributor Author

svsdep commented Mar 11, 2018

//cc @PanAeon @jraygauthier

@svsdep
Copy link
Contributor Author

svsdep commented Mar 17, 2018

I will gladly add myself as an maintainer if no one wills to do this.

@jraygauthier
Copy link
Member

@svsdep: Seems fine to me so long as tested to be working.

@rycee
Copy link
Member

rycee commented Mar 21, 2018

Works well for me so I rebased it to master in 044d4b0. I noticed, however, that 8.18.0.6 is available so perhaps need to update again?

@rycee rycee closed this Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants