Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flyway: refactor supported platforms #36432

Closed
wants to merge 1 commit into from
Closed

flyway: refactor supported platforms #36432

wants to merge 1 commit into from

Conversation

pukkamustard
Copy link
Contributor

@pukkamustard pukkamustard commented Mar 7, 2018 •
edited

Motivation for this change

Other Unix platforms are supported (not only Linux).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pukkamustard
flyway: refactor supported platforms
d51aaa3 
Other Unix platforms are supported (not only Linux).
@rycee
Copy link
Member

rycee commented Mar 12, 2018

Looks good! I've rebased to master in 1993ebf. Thanks for the contribution!

@rycee rycee closed this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pukkamustard @rycee @GrahamcOfBorg @Janik-Haag