New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emacs: use unstable melpa for dependencies #36423
emacs: use unstable melpa for dependencies #36423
Conversation
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
pkgs/top-level/emacs-packages.nix
Outdated
@@ -385,9 +385,9 @@ let | |||
in | |||
lib.makeScope newScope (self: | |||
{} | |||
// melpaPackages self | |||
// elpaPackages self | |||
// melpaStablePackages self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every package in melpaStablePackages
is also in melpaPackages
, so we can remove this line to improve evaluation performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is some people might be using the nixpkgs.emacsPackagesNg.melpaStablePackages
attribute set. This will at least preserve that for them until a better solution can be found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not saying to remove melpaStablePackages
, I'm saying to stop inheriting everything from it into the default package set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay did that, thanks! I'm not 100% on how this all works but I'm not sure if there is anyway to access "melpaStablePackages" now that it is not in the scope. At least this now fails:
nix-build -A emacsPackagesNg.melpaStablePackages.magit
371a578
to
fa64930
Compare
Ok updated with changes. Thanks! |
remove melpaStablePackages from default scope
fa64930
to
635114b
Compare
Actually things broke removing melpaStablePackages. Will keep it as a compromise until we can find a better solution to this issue. |
Lowering the priority of melpaStablePackages (NixOS#36423) leaves elpaPackages ahead of melpaPackages; the former carries outdated dependencies which should be overridden by melpaPackages. See also: NixOS#36423
Motivation for this change
See #36345 for discussion. This should fix issues with MELPA stable being out of date occasionaly.
/cc @ttuegel