Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/i18n: add option for extra locale settings #36424

Merged
merged 1 commit into from Nov 29, 2018
Merged

nixos/i18n: add option for extra locale settings #36424

merged 1 commit into from Nov 29, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

There doesn't seem to be a simple way to add additional locale settings to /etc/locale.conf.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Nov 29, 2018

not sure why this has been delayed so much. Applied this locally on master and tested the settings in a VM 👍

@Ma27 Ma27 merged commit 45c6794 into NixOS:master Nov 29, 2018
@jfrankenau jfrankenau deleted the i18n-extra-locale branch November 29, 2018 17:57
@jfrankenau
Copy link
Member Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @Ma27 @GrahamcOfBorg