Skip to content

Commit

Permalink
gdb: Flexible target matching for darwin
Browse files Browse the repository at this point in the history
Outside of the nix-build the target is `x86_64-apple-darwin17.4.0`,
while inside the target is `x86_64-apple-darwin`. This difference
causes the fallback target configuration for darwin, which disables
gdb. Add a patch to make the target matching more flexible.

(cherry picked from commit 4c76a21)
  • Loading branch information
thefloweringash authored and LnL7 committed Mar 7, 2018
1 parent e02a9ba commit fe0728f
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
11 changes: 11 additions & 0 deletions pkgs/development/tools/misc/gdb/darwin-target-match.patch
@@ -0,0 +1,11 @@
--- a/configure 2017-06-05 00:51:26.000000000 +0900
+++ b/configure 2018-03-06 23:12:58.000000000 +0900
@@ -3603,7 +3603,7 @@
noconfigdirs="$noconfigdirs ld gprof"
noconfigdirs="$noconfigdirs sim target-rda"
;;
- x86_64-*-darwin[912]*)
+ x86_64-*-darwin*)
noconfigdirs="$noconfigdirs ld gas gprof"
noconfigdirs="$noconfigdirs sim target-rda"
;;
3 changes: 2 additions & 1 deletion pkgs/development/tools/misc/gdb/default.nix
Expand Up @@ -34,7 +34,8 @@ stdenv.mkDerivation rec {
sha256 = "1qwmcbaxf0jc7yjl0fimgcfj2yqcrl6h7azgs1d838kbwf9mzg9x";
};

patches = [ ./debug-info-from-env.patch ];
patches = [ ./debug-info-from-env.patch ]
++ stdenv.lib.optional stdenv.isDarwin ./darwin-target-match.patch;

nativeBuildInputs = [ pkgconfig texinfo perl setupDebugInfoDirs ]
# TODO(@Ericson2314) not sure if should be host or target
Expand Down

0 comments on commit fe0728f

Please sign in to comment.