satysfi: init at 2018-03-07 #36428

mt-caret · 2018-03-07T16:05:31Z

Motivation for this change

A typesetting system.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

mt-caret · 2018-03-10T04:52:57Z

ping @vbgl

vbgl · 2018-03-10T09:37:15Z

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_06.satysfi

vbgl · 2018-03-10T09:54:45Z

Since this is not an OCaml library, it does not belong to pkgs/top-level/ocaml-packages.nix, ocamlPackages, nor pkgs/development/ocaml-modules.

GrahamcOfBorg · 2018-03-10T09:59:41Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/156xdjzrfhkwac2ibmac5zn64cr2b0zj-ocaml4.06.1-core_kernel-0.10.0
shrinking /nix/store/156xdjzrfhkwac2ibmac5zn64cr2b0zj-ocaml4.06.1-core_kernel-0.10.0/lib/ocaml/4.06.1/site-lib/core_kernel/core_kernel.cmxs
shrinking /nix/store/156xdjzrfhkwac2ibmac5zn64cr2b0zj-ocaml4.06.1-core_kernel-0.10.0/lib/ocaml/4.06.1/site-lib/core_kernel/base_for_tests/base_for_tests.cmxs
shrinking /nix/store/156xdjzrfhkwac2ibmac5zn64cr2b0zj-ocaml4.06.1-core_kernel-0.10.0/lib/ocaml/4.06.1/site-lib/stubslibs/dllcore_kernel_stubs.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/156xdjzrfhkwac2ibmac5zn64cr2b0zj-ocaml4.06.1-core_kernel-0.10.0/lib 
patching script interpreter paths in /nix/store/156xdjzrfhkwac2ibmac5zn64cr2b0zj-ocaml4.06.1-core_kernel-0.10.0
checking for references to /tmp/nix-build-ocaml4.06.1-core_kernel-0.10.0.drv-0 in /nix/store/156xdjzrfhkwac2ibmac5zn64cr2b0zj-ocaml4.06.1-core_kernel-0.10.0...
cannot build derivation ‘/nix/store/2sc1jqmd3mmj5dckscvjca3g86jmpap8-satysfi-2018-03-07.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/2sc1jqmd3mmj5dckscvjca3g86jmpap8-satysfi-2018-03-07.drv’ failed

GrahamcOfBorg · 2018-03-10T10:06:07Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/m9s5m9mvn035gbc7d9ajif2ck73cwnr4-ocaml4.06.1-core_kernel-0.10.0
shrinking /nix/store/m9s5m9mvn035gbc7d9ajif2ck73cwnr4-ocaml4.06.1-core_kernel-0.10.0/lib/ocaml/4.06.1/site-lib/stubslibs/dllcore_kernel_stubs.so
shrinking /nix/store/m9s5m9mvn035gbc7d9ajif2ck73cwnr4-ocaml4.06.1-core_kernel-0.10.0/lib/ocaml/4.06.1/site-lib/core_kernel/core_kernel.cmxs
shrinking /nix/store/m9s5m9mvn035gbc7d9ajif2ck73cwnr4-ocaml4.06.1-core_kernel-0.10.0/lib/ocaml/4.06.1/site-lib/core_kernel/base_for_tests/base_for_tests.cmxs
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/m9s5m9mvn035gbc7d9ajif2ck73cwnr4-ocaml4.06.1-core_kernel-0.10.0/lib
patching script interpreter paths in /nix/store/m9s5m9mvn035gbc7d9ajif2ck73cwnr4-ocaml4.06.1-core_kernel-0.10.0
checking for references to /build in /nix/store/m9s5m9mvn035gbc7d9ajif2ck73cwnr4-ocaml4.06.1-core_kernel-0.10.0...
cannot build derivation '/nix/store/akzna1y18hmf0xvf3mf9j0q7r7200w7c-satysfi-2018-03-07.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/akzna1y18hmf0xvf3mf9j0q7r7200w7c-satysfi-2018-03-07.drv' failed

mt-caret · 2018-03-10T10:06:45Z

Fixed.

vbgl · 2018-03-10T20:35:03Z

pkgs/tools/typesetting/satysfi/default.nix

@@ -0,0 +1,40 @@
+{ stdenv, fetchzip, fetchFromGitHub, ocaml, ocamlbuild, findlib, menhir,
+  ppx_deriving, uutf, result, core_kernel, bitv, batteries, yojson, camlimages }:


Can you take ocamlPackages as one argument all libraries separately?

vbgl · 2018-03-10T20:35:59Z

pkgs/tools/typesetting/satysfi/default.nix

+      homepage = https://github.com/gfngfn/SATySFi;
+      description = "A statically-typed, functional typesetting system";
+      license = licenses.lgpl3;
+      maintainers = [ maintainers.mt-caret ];


Please add a platforms attribute.

vbgl · 2018-03-10T20:37:35Z

pkgs/tools/typesetting/satysfi/default.nix

+    };
+    buildInputs = [ findlib menhir ppx_deriving uutf result core_kernel bitv
+      batteries yojson camlimages ];
+    nativeBuildInputs = [ ocaml ocamlbuild ];


Why this split between buildInputs and nativeBuildInputs?

I guessed ocaml and ocamlbuild were only needed at build time. So this should all be in buildInputs?

vbgl · 2018-03-10T20:40:13Z

pkgs/tools/typesetting/satysfi/default.nix

+  lm-math = fetchzip {
+    url = "http://www.gust.org.pl/projects/e-foundry/lm-math/download/latinmodern-math-1959.zip";
+    sha256 = "15l3lxjciyjmbh0q6jjvzz16ibk4ij79in9fs47qhrfr2wrddpvs";
+    stripRoot = false;


What’s the purpose of this stripRoot here?

vbgl · 2018-03-11T10:15:26Z

Does it work correctly? I tried the tests from https://github.com/gfngfn/SATySFi/tree/master/tests and got:

satysfi list.satyh math.satyh head.satyh first.saty -o output.pdf
 ---- ---- ---- ----
  target file: 'output.pdf'
! [Error] package file not found: dist/hash/default-font.satysfi-hash
make: *** [Makefile:4: all] Error 1

mt-caret · 2018-03-11T11:42:39Z

Yeah, that's a known issue (gfngfn/SATySFi#17) (and probably one of the reasons why there's no official version out yet). Copying everything from ./dist to ~/.satysfi will fix it, but AFAIK that can't be done at build-time in Nix; I believe SATySFi currently looks for various files in hardcoded paths but that will change in the future.

vbgl · 2018-03-11T13:35:45Z

It’s easy to fix these hardcoded paths at configure-time. With this change, I could compile the math1 example from the tests directory (other examples fail due to missing fonts).

mt-caret added 2 commits March 8, 2018 01:02

satysfi: init at 2018-03-07

4a35e9f

include version in package name

5bbd3ac

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Mar 7, 2018

vbgl added 8.has: package (new) 6.topic: ocaml labels Mar 10, 2018

fix location

2975e97

GrahamcOfBorg added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 labels Mar 10, 2018

vbgl requested changes Mar 10, 2018

View reviewed changes

fix

f00eee4

GrahamcOfBorg added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 labels Mar 11, 2018

satysfi: fix reference to share directory

388a0ee

vbgl approved these changes Mar 11, 2018

View reviewed changes

vbgl merged commit cce7d1b into NixOS:master Mar 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

satysfi: init at 2018-03-07 #36428

satysfi: init at 2018-03-07 #36428

mt-caret commented Mar 7, 2018

mt-caret commented Mar 10, 2018

vbgl commented Mar 10, 2018

vbgl commented Mar 10, 2018

GrahamcOfBorg commented Mar 10, 2018

GrahamcOfBorg commented Mar 10, 2018

mt-caret commented Mar 10, 2018

vbgl Mar 10, 2018

vbgl Mar 10, 2018

vbgl Mar 10, 2018

mt-caret Mar 11, 2018

vbgl Mar 10, 2018

vbgl commented Mar 11, 2018

mt-caret commented Mar 11, 2018

vbgl commented Mar 11, 2018

		@@ -0,0 +1,40 @@
		{ stdenv, fetchzip, fetchFromGitHub, ocaml, ocamlbuild, findlib, menhir,
		ppx_deriving, uutf, result, core_kernel, bitv, batteries, yojson, camlimages }:

satysfi: init at 2018-03-07 #36428

satysfi: init at 2018-03-07 #36428

Conversation

mt-caret commented Mar 7, 2018

Motivation for this change

Things done

mt-caret commented Mar 10, 2018

vbgl commented Mar 10, 2018

vbgl commented Mar 10, 2018

GrahamcOfBorg commented Mar 10, 2018

GrahamcOfBorg commented Mar 10, 2018

mt-caret commented Mar 10, 2018

vbgl Mar 10, 2018

Choose a reason for hiding this comment

vbgl Mar 10, 2018

Choose a reason for hiding this comment

vbgl Mar 10, 2018

Choose a reason for hiding this comment

mt-caret Mar 11, 2018

Choose a reason for hiding this comment

vbgl Mar 10, 2018

Choose a reason for hiding this comment

vbgl commented Mar 11, 2018

mt-caret commented Mar 11, 2018

vbgl commented Mar 11, 2018