Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zziplib: 0.13.67 -> 0.13.68 #35421

Merged
merged 3 commits into from Feb 24, 2018
Merged

zziplib: 0.13.67 -> 0.13.68 #35421

merged 3 commits into from Feb 24, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 23, 2018 •
edited

Motivation for this change

Bump zziplib to 0.13.68 to fix multiple CVE issues:

Unfortunately, getting only those patches is hard, as they're not well referenced to linked issues.
The testsuite is currently broken, and the newer python testsuite checking for vulns requires network access.

gdraheim/zziplib#20 might still be an issue, so keeping this as a TODO here.
Vulnerability roundup 37 (master) #35408

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz fpletz changed the title zziplib 0.13.67 -> 0.13.68 zziplib: 0.13.67 -> 0.13.68 Feb 23, 2018
@fpletz
Copy link
Member

fpletz commented Feb 23, 2018

@GrahamcOfBorg build zziplib

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

make[3]: Nothing to be done for 'install-exec-am'.
make[3]: Nothing to be done for 'install-data-am'.
make[3]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.68.drv-0/zziplib-0.13.68/i386-apple-darwin16.3.0'
make[2]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.68.drv-0/zziplib-0.13.68/i386-apple-darwin16.3.0'
make[1]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.68.drv-0/zziplib-0.13.68/i386-apple-darwin16.3.0'
post-installation fixup
gzipping man pages under /nix/store/d0nq0d966syw2rgw7mx9gvn8n2g0bys3-zziplib-0.13.68/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/d0nq0d966syw2rgw7mx9gvn8n2g0bys3-zziplib-0.13.68/lib  /nix/store/d0nq0d966syw2rgw7mx9gvn8n2g0bys3-zziplib-0.13.68/bin
patching script interpreter paths in /nix/store/d0nq0d966syw2rgw7mx9gvn8n2g0bys3-zziplib-0.13.68

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/bin/zzcat
shrinking /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/lib/libzzipwrap-0.so.13.0.68
shrinking /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/lib/libzzipfseeko-0.so.13.0.68
shrinking /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/lib/libzzipmmapped-0.so.13.0.68
shrinking /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/lib/libzzip-0.so.13.0.68
gzipping man pages under /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/lib  /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/bin
patching script interpreter paths in /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68
checking for references to /build in /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68...

@flokli
zziplib: 0.13.67 -> 0.13.68
9f6a942 
Bump zziplib to 0.13.68 to fix multiple CVE issues:

 - CVE-2018-6381
 (gdraheim/zziplib@a803559)
 - CVE-2018-6484
 (gdraheim/zziplib#14 (comment))
 - CVE-2018-6540
 (gdraheim/zziplib@72ec933)
 - CVE-2018-6541
 (gdraheim/zziplib#16 (comment))
 - CVE-2018-6542
 (gdraheim/zziplib@931f962)

Unfortunately, getting only those patches is hard, as they're not well
referenced to linked issues. The testsuite checking for vulns
requires network access (so we can't easily test it here).

gdraheim/zziplib#20 might still be an issue,
so keeping this as a TODO here.
@adisbladis
Copy link
Member

Causes ~1200 rebuilds. Maybe it should go to staging?

@flokli flokli changed the base branch from master to staging February 24, 2018 08:47
@flokli
Copy link
Contributor Author

flokli commented Feb 24, 2018

@adisbladis Base changed to staging.

@adisbladis adisbladis merged commit 6f13032 into NixOS:staging Feb 24, 2018
@adisbladis
Copy link
Member

@flokli Thank you 👍

@flokli flokli deleted the CVE-zziplib-0.13.67 branch February 24, 2018 16:21
vcunat pushed a commit that referenced this pull request Mar 7, 2018
@adisbladis @vcunat
Merge pull request #35421 from flokli/CVE-zziplib-0.13.67
f93e902 
zziplib: 0.13.67 -> 0.13.68
(cherry picked from commit 6f13032)
Security fixes inside.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flokli @fpletz @GrahamcOfBorg @adisbladis @vcunat