Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security update for libtiff #35396

Closed
wants to merge 1 commit into from
Closed

Security update for libtiff #35396

wants to merge 1 commit into from

Conversation

ctheune
Copy link
Contributor

@ctheune ctheune commented Feb 23, 2018

Motivation for this change

Backport for the master change that updates libtiff, which has multiple CVEs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I guess asking @grahamc @fpletz for a merge is the right thing to do ... ? :)

(And paging @ckauhaus just for good measure in case I'm screwing something up here.)

@ctheune ctheune changed the base branch from master to staging-17.09 February 23, 2018 14:04
@ctheune
Copy link
Contributor Author

ctheune commented Feb 23, 2018

Sorry for the noise. I accidentally created the PR with master as target first ... that's fixed now. staging-17.09 is hopefully the right target.

@fpletz fpletz closed this Feb 23, 2018
@fpletz
Copy link
Member

fpletz commented Feb 23, 2018

Thanks for making us aware of this. 👍

Two things:

  • staging-17.09 was a temporary branch that was used during the freeze of 17.09. I've deleted it.
  • Please use cherry-pick -x to backport commits to retain a reference to the commit that was cherry-picked.

I've cherry-picked and pushed that commit.

@fpletz
Copy link
Member

fpletz commented Feb 23, 2018

Forgot to mention this PR in the commit. Here it is: ea0c4b5

@Ericson2314 Ericson2314 removed their request for review February 24, 2018 02:16
@ctheune
Copy link
Contributor Author

ctheune commented Feb 28, 2018

Thanks a lot @fpletz! I'll try to remember the cherry-pick thing. Is there a page where I can look this up in case I forget this when making the next PR?

@ctheune ctheune deleted the ctheune-17.09-update-libtiff branch February 28, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@FRidh FRidh Awaiting requested review from FRidh

@nbp nbp Awaiting requested review from nbp

@orivej orivej Awaiting requested review from orivej

@peti peti Awaiting requested review from peti

@ttuegel ttuegel Awaiting requested review from ttuegel

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: emacs 6.topic: erlang 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos 6.topic: policy discussion 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: steam 6.topic: vim 8.has: changelog 8.has: documentation 8.has: module (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctheune @fpletz @GrahamcOfBorg