Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mattermost: add build number #35422

Merged
merged 1 commit into from Feb 23, 2018
Merged

mattermost: add build number #35422

merged 1 commit into from Feb 23, 2018

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Feb 23, 2018

  • built and tested on NixOS
  • verified "nixpkgs-4.7.2" appears on the "About Mattermost" page

I'm generally not excited about the way Mattermost needs an external specification of the BUILD_NUMBER to get the version in there, but, if we are going to build the package from source, we need to get the version number in there. Since we have our own way of building this package (we don't use the provided Makefile) and to disambiguate our version from the official source release, I prefixed the build number with "nixpkgs-".

@ryantm
Copy link
Member Author

ryantm commented Feb 23, 2018

@GrahamcOfBorg build mattermost

fpletz
fpletz reviewed Feb 23, 2018
View reviewed changes
pkgs/servers/mattermost/default.nix Outdated
runHook postBuild
'';

buildFlags = "-ldflags \"-X '${goPackagePath}/model.BuildNumber=nixpkgs-${version}'\"";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move buildFlags up into a let expression? This is not needed in the build environment. :)

@ryantm
Copy link
Member Author

ryantm commented Feb 23, 2018

@fpletz Thanks for reviewing! I made the changes you asked for. Can you please review it again?

@fpletz
Copy link
Member

fpletz commented Feb 23, 2018

Thanks! The build bot has a whiltelist of users who can trigger it.

@GrahamcOfBorg build mattermost

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/jwadi7w2a2j08kxwqsmmnxflaj75i7ki-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/stretchr/testify/.travis.gogenerate.sh: interpreter directive changed from "/bin/bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/jwadi7w2a2j08kxwqsmmnxflaj75i7ki-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/stretchr/testify/.travis.govet.sh: interpreter directive changed from "/bin/bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/jwadi7w2a2j08kxwqsmmnxflaj75i7ki-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/plan9/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/jwadi7w2a2j08kxwqsmmnxflaj75i7ki-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/plan9/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/jwadi7w2a2j08kxwqsmmnxflaj75i7ki-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/plan9/mksysnum_plan9.sh: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/jwadi7w2a2j08kxwqsmmnxflaj75i7ki-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/jwadi7w2a2j08kxwqsmmnxflaj75i7ki-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/jwadi7w2a2j08kxwqsmmnxflaj75i7ki-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash -e"
/nix/store/jwadi7w2a2j08kxwqsmmnxflaj75i7ki-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/gopkg.in/olivere/elastic.v5/run-es.sh: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/dwrgj6zn88mva38cbhpzf2j5w2layrwg-mattermost-4.7.2-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/8vpkr5l4yq04b4d1a8p0arminv3i3154-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/8vpkr5l4yq04b4d1a8p0arminv3i3154-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/8vpkr5l4yq04b4d1a8p0arminv3i3154-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash -e"
/nix/store/8vpkr5l4yq04b4d1a8p0arminv3i3154-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/gopkg.in/olivere/elastic.v5/run-es.sh: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/8vpkr5l4yq04b4d1a8p0arminv3i3154-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/scripts/ldap-check.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/8vpkr5l4yq04b4d1a8p0arminv3i3154-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/scripts/license-check.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/8vpkr5l4yq04b4d1a8p0arminv3i3154-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/scripts/prereq-check.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/8vpkr5l4yq04b4d1a8p0arminv3i3154-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/scripts/test-xprog.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/8vpkr5l4yq04b4d1a8p0arminv3i3154-mattermost-4.7.2...
/nix/store/iyyd9vdza9s1zk4nsygfgg02639x41jz-mattermost-4.7.2-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/firgdhilcmva139sfwbirl0xn3kvgsn3-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/prometheus/procfs/ttar: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/firgdhilcmva139sfwbirl0xn3kvgsn3-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/lib/pq/.travis.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/firgdhilcmva139sfwbirl0xn3kvgsn3-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/mattermost/gorp/test_all.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash -e"
/nix/store/firgdhilcmva139sfwbirl0xn3kvgsn3-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/mattermost/rsc/mkapp: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/firgdhilcmva139sfwbirl0xn3kvgsn3-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/scripts/ldap-check.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/firgdhilcmva139sfwbirl0xn3kvgsn3-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/scripts/test-xprog.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/firgdhilcmva139sfwbirl0xn3kvgsn3-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/scripts/prereq-check.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/firgdhilcmva139sfwbirl0xn3kvgsn3-mattermost-4.7.2/share/go/src/github.com/mattermost/mattermost-server/scripts/license-check.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-mattermost-4.7.2.drv-0 in /nix/store/firgdhilcmva139sfwbirl0xn3kvgsn3-mattermost-4.7.2...
/nix/store/1j49qi6lg524vmkd3dfsg4s7g2qlwk80-mattermost-4.7.2-bin

@ryantm ryantm mentioned this pull request Feb 23, 2018
Closed
@Mic92 Mic92 merged commit 7d37688 into NixOS:master Feb 23, 2018
@ryantm ryantm deleted the mattermost-fix branch April 13, 2018 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryantm @fpletz @GrahamcOfBorg @Mic92