Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hydra build (gcc7) #35400

Closed
wants to merge 3 commits into from
Closed

Fix Hydra build (gcc7) #35400

wants to merge 3 commits into from

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Feb 23, 2018 •
edited

Motivation for this change

Hydra dependencies were broken with gcc7. I've also fond aws-sdk-cpp override which pointed to some old @edolstra fork with patches that are mostly in upstream. So I updated aws-sdk-cpp to latest version and added hotpatch override for hydra (hope this is ok) also pqxx was too old.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • [ X] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lblasc
libpqxx: 4.0.1 -> 6.1.0
fe2e4ac
@lblasc
aws-sdk-cpp: 1.3.22 -> 1.4.4
f91d22e
@lblasc
hydra: use latest available aws-sdk-cpp version
290c56e 
After examination of edolstra's aws-sdk-cpp "local" branch:
https://github.com/edolstra/aws-sdk-cpp/commits/local

Only bf5ef0cab4221c0fab0a9c71b180462e08d92dcf patch is not in upstream,
which changes logging to stderr, now we hotpatch this before building.
@edolstra
Copy link
Member

See #35125.

@lblasc
Copy link
Contributor Author

lblasc commented Feb 23, 2018

Duplicate, seems like #35125 is in better shape for merging. Closing, thx.

@lblasc lblasc closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lblasc @edolstra @GrahamcOfBorg @Janik-Haag