syncthing-gtk: 0.9.2.7 → 0.9.3 #35410

jtojnar · 2018-02-23T17:52:56Z

Motivation for this change

https://github.com/syncthing/syncthing-gtk/releases/tag/v0.9.3

It is supposed to fix the UI freezes, though it certainly does not for me.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-02-23T18:02:43Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: while evaluating the attribute 'patches' of the derivation 'syncthing-gtk-0.9.3' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating the attribute 'killall' of the derivation 'paths.patch' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:4313:12:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/psmisc/default.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/psmisc/default.nix:3:1

GrahamcOfBorg · 2018-02-23T18:03:39Z

Success on aarch64-linux (full log)

Partial log (click to expand)

writing dependency_links to syncthing_gtk.egg-info/dependency_links.txt
reading manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
writing manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/sqrbypq79li7x0g6kgdkmzfpz9r66k1p-syncthing-gtk-0.9.3

GrahamcOfBorg · 2018-02-23T19:17:04Z

Success on x86_64-linux (full log)

Partial log (click to expand)

writing top-level names to syncthing_gtk.egg-info/top_level.txt
writing dependency_links to syncthing_gtk.egg-info/dependency_links.txt
reading manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
writing manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

grahamc · 2018-02-24T03:20:38Z

I'm sorry, I didn't intend to click on this window at all.

GrahamcOfBorg · 2018-02-24T03:30:07Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: while evaluating the attribute 'patches' of the derivation 'syncthing-gtk-0.9.3' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating the attribute 'killall' of the derivation 'paths.patch' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:4313:12:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/psmisc/default.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:74:12:
assertion failed at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/psmisc/default.nix:3:1

GrahamcOfBorg · 2018-02-24T03:30:30Z

Success on aarch64-linux (full log)

Partial log (click to expand)

writing dependency_links to syncthing_gtk.egg-info/dependency_links.txt
reading manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
writing manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/sqrbypq79li7x0g6kgdkmzfpz9r66k1p-syncthing-gtk-0.9.3

GrahamcOfBorg · 2018-02-24T03:32:51Z

Success on x86_64-linux (full log)

Partial log (click to expand)

writing top-level names to syncthing_gtk.egg-info/top_level.txt
writing dependency_links to syncthing_gtk.egg-info/dependency_links.txt
reading manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
writing manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

jtojnar · 2018-02-25T05:22:12Z

@cumber Could you please test this and share the output of running syncthing-gtk -d in the terminal?

GrahamcOfBorg · 2018-02-25T05:28:25Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘python2.7-pyinotify-0.9.6’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/python-packages.nix:13827 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-25T05:28:30Z

Success on x86_64-linux (full log)

Partial log (click to expand)

writing top-level names to syncthing_gtk.egg-info/top_level.txt
writing dependency_links to syncthing_gtk.egg-info/dependency_links.txt
reading manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
writing manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

GrahamcOfBorg · 2018-02-25T06:32:57Z

Success on aarch64-linux (full log)

Partial log (click to expand)

writing dependency_links to syncthing_gtk.egg-info/dependency_links.txt
reading manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
writing manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/6dic3qxvckpw1lb8pzyg3a83bxks7mjr-syncthing-gtk-0.9.3

cumber · 2018-02-25T22:29:24Z

Tested it, and got the UI freezing on startup. Sometimes it displays the "Starting Syncthing daemon" pop-up, sometimes it doesn't. Neither pop-up nor the main window responds to anything.

But that's also happening for me now with 0.9.2.7; I'm not sure when that changed, since I haven't actually needed anything synced since the last PR I tested.

Not sure if you still want the -d output since it isn't working for me either, but here it is:

D UIBuilder     Enabled: header_bar
D UIBuilder     Enabled: icons_in_menu
D UIBuilder     Loading glade file /nix/store/7g5y4jcc265bk6lgics0cxb3gs81y8jz-syncthing-gtk-0.9.3/share/syncthing-gtk/app.glade
D UIBuilder     Enabled conditions: set([u'icons_in_menu', u'header_bar'])
D UIBuilder     Removed 'property' by attribute: is_windows
D UIBuilder     Removed 'property' by attribute: is_windows
D UIBuilder     Allowed node icons_in_menu | old_gtk
D UIBuilder     Removed 'property' by attribute: is_windows
D UIBuilder     Allowed node !is_gnome | old_gtk
D UIBuilder     Allowed node icons_in_menu | old_gtk
D UIBuilder     Removed 'property' by attribute: old_gtk
D UIBuilder     Allowed node icons_in_menu | old_gtk
D UIBuilder     Allowed node icons_in_menu | old_gtk
D UIBuilder     Removed 'child' by attribute: traditional_header
D UIBuilder     Removed 'child' by attribute: is_windows
D UIBuilder     Allowed node icons_in_menu | old_gtk
D UIBuilder     Removed 'property' by attribute: is_windows
D UIBuilder     Removed node traditional_header
D UIBuilder     Allowed node traditional_header | icons_in_menu
I StatusIcon    Using backend StatusIconGTK3 (primary)
D Daemon        Reading syncthing config /home/cumber/.config/syncthing/config.xml
V Notifications Error notifications enabled
V Notifications File update notifications enabled
V Daemon        Set refresh interval to 1

(.syncthing-gtk-wrapped:17581): Gtk-WARNING **: Invalid icon size 24

(.syncthing-gtk-wrapped:17581): Gdk-CRITICAL **: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed
D InfoBox       alyamar state changed to Disconnected
/nix/store/98bghm0wfyh6ygvr0yg6slyl5xnnj5hs-python2.7-pygobject-3.26.1/lib/python2.7/site-packages/gi/module.py:176: Warning: cannot register existing type 'RsvgHandle'
  g_type = info.get_g_type()
/nix/store/98bghm0wfyh6ygvr0yg6slyl5xnnj5hs-python2.7-pygobject-3.26.1/lib/python2.7/site-packages/gi/module.py:176: Warning: g_once_init_leave: assertion 'result != 0' failed
  g_type = info.get_g_type()
/nix/store/98bghm0wfyh6ygvr0yg6slyl5xnnj5hs-python2.7-pygobject-3.26.1/lib/python2.7/site-packages/gi/module.py:210: Warning: g_type_get_qdata: assertion 'node != NULL' failed
  type_ = g_type.pytype
/nix/store/98bghm0wfyh6ygvr0yg6slyl5xnnj5hs-python2.7-pygobject-3.26.1/lib/python2.7/site-packages/gi/module.py:224: Warning: g_type_get_qdata: assertion 'node != NULL' failed
  g_type.pytype = wrapper
/nix/store/98bghm0wfyh6ygvr0yg6slyl5xnnj5hs-python2.7-pygobject-3.26.1/lib/python2.7/site-packages/gi/module.py:224: Warning: g_type_set_qdata: assertion 'node != NULL' failed
  g_type.pytype = wrapper

xeji · 2018-04-28T19:48:53Z

0.9.3.1 was released in March

jtojnar · 2018-04-28T19:50:31Z

I am aware, I am still unable to test this due to https://gitlab.gnome.org/GNOME/librsvg/issues/210.

jtojnar · 2018-04-28T20:01:49Z

Actually, I switched from tray area to appindicator, so it no longer freezes for me.

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Feb 23, 2018

grahamc closed this Feb 24, 2018

grahamc reopened this Feb 24, 2018

jtojnar force-pushed the syncthing-gtk-0.9.3 branch from a46f4f9 to c35feca Compare February 25, 2018 05:20

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 labels Feb 25, 2018

syncthing-gtk: 0.9.2.7 → 0.9.3.1

094683a

jtojnar force-pushed the syncthing-gtk-0.9.3 branch from c35feca to 094683a Compare April 28, 2018 20:00

jtojnar merged commit f92d936 into NixOS:master Apr 28, 2018

jtojnar deleted the syncthing-gtk-0.9.3 branch April 28, 2018 20:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

syncthing-gtk: 0.9.2.7 → 0.9.3 #35410

syncthing-gtk: 0.9.2.7 → 0.9.3 #35410

jtojnar commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

grahamc commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

jtojnar commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

cumber commented Feb 25, 2018

xeji commented Apr 28, 2018

jtojnar commented Apr 28, 2018

jtojnar commented Apr 28, 2018

syncthing-gtk: 0.9.2.7 → 0.9.3 #35410

syncthing-gtk: 0.9.2.7 → 0.9.3 #35410

Conversation

jtojnar commented Feb 23, 2018

Motivation for this change

Things done

GrahamcOfBorg commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

grahamc commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

GrahamcOfBorg commented Feb 24, 2018

jtojnar commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

cumber commented Feb 25, 2018

xeji commented Apr 28, 2018

jtojnar commented Apr 28, 2018

jtojnar commented Apr 28, 2018