Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.curtsies: fix build #35394

Closed
wants to merge 1 commit into from
Closed

pythonPackages.curtsies: fix build #35394

wants to merge 1 commit into from

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 23, 2018

Motivation for this change

It's missing a dependency apparently.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (none, library)
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj requested a review from FRidh as a code owner February 23, 2018 13:39
@dotlambda
Copy link
Member

fixed in #35198

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 23, 2018

It still fails for me on master (54371a7).

builder for '/nix/store/x68zd6k4031mwhllk0pmkp9a0r5mvqi4-python3.6-curtsies-0.3.0.drv' failed with exit code 1; last 10 log lines:
  adding 'curtsies-0.3.0.dist-info/top_level.txt'
  adding 'curtsies-0.3.0.dist-info/WHEEL'
  adding 'curtsies-0.3.0.dist-info/METADATA'
  adding 'curtsies-0.3.0.dist-info/RECORD'
  installing
  /build/curtsies-0.3.0/dist /build/curtsies-0.3.0
  Processing ./curtsies-0.3.0-py2.py3-none-any.whl
  Collecting typing (from curtsies==0.3.0)
    Could not find a version that satisfies the requirement typing (from curtsies==0.3.0) (from versions: )
  No matching distribution found for typing (from curtsies==0.3.0)
[0 built (1 failed)]
error: build of '/nix/store/x68zd6k4031mwhllk0pmkp9a0r5mvqi4-python3.6-curtsies-0.3.0.drv' failed

@dotlambda
Copy link
Member

The commit is still only in staging.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 23, 2018

Ah, ok. Thanks.

@rnhmjoj rnhmjoj closed this Feb 23, 2018
@rnhmjoj rnhmjoj deleted the next branch February 23, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @dotlambda @GrahamcOfBorg