Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage: explicitly use gfortran6 #35404

Merged
merged 1 commit into from Feb 23, 2018
Merged

sage: explicitly use gfortran6 #35404

merged 1 commit into from Feb 23, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Feb 23, 2018 •
edited

Motivation for this change

The recent change from gfortran=gfortran6 to gfortran=gfortran7 broke
the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau
sage: explicitly use gfortran6
89162cd 
The recent change from gfortran=gfortran6 to gfortran=gfortran7 broke
the build.
@Mic92
Copy link
Member

Mic92 commented Feb 23, 2018

@GrahamcOfBorg build sage

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

  build directory: /nix/store/40r0l6as0zk9993fqiwbxid4cba4xd85-sage-8.1/var/tmp/sage/build/mpir-3.0.0-644faf502c56f97d9accd301965fc57d6ec70868

The build directory may contain configuration files and other potentially
helpful information. WARNING: if you now run 'make' again, the build
directory will, by default, be deleted. Set the environment variable
SAGE_KEEP_BUILT_SPKGS to 'yes' to prevent this.

make: *** [Makefile:18: all-build] Error 1
builder for '/nix/store/xigly4kfk43c3ckv6yvj30chda4dvxnx-sage-8.1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/xigly4kfk43c3ckv6yvj30chda4dvxnx-sage-8.1.drv' failed

@timokau
Copy link
Member Author

timokau commented Feb 23, 2018

The sage build is too long for ofBorg, it doesn't complete within the time limit.

@vcunat
Copy link
Member

vcunat commented Feb 23, 2018

Did you try it locally? IIRC I've tried building with gfortran6 but it didn't help.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘sage-8.1’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/science/math/sage/default.nix:217 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

[xz-5.2.2] checking for immintrin.h... yes
[xz-5.2.2] checking for stdbool.h that conforms to C99... yes
[xz-5.2.2] checking for _Bool... yes
[xz-5.2.2] checking for uint8_t... yes
[xz-5.2.2] checking for uint16_t... yes
[xz-5.2.2] checking for int32_t... yes
[xz-5.2.2] checking for uint32_t... yes
[xz-5.2.2] checking for int64_t... yes
building of ‘/nix/store/xbig8991ds1rp8n75nx3bvisxfxir4mw-sage-8.1.drv’ timed out after 3600 seconds
error: build of ‘/nix/store/xbig8991ds1rp8n75nx3bvisxfxir4mw-sage-8.1.drv’ failed

@timokau
Copy link
Member Author

timokau commented Feb 23, 2018

Yes, I made sure that I can reproduce the failure and that reverting to gfortran6 fixes it.

@vcunat
Copy link
Member

vcunat commented Feb 23, 2018

Hmm, my machine apparently tends to suffer from transient errors on sage. Tried twice now, succeeded in the second case.

@vcunat vcunat merged commit 89162cd into NixOS:master Feb 23, 2018
vcunat added a commit that referenced this pull request Feb 23, 2018
@vcunat
Merge #35404: sage: explicitly use gfortran6
296fa60
@timokau
Copy link
Member Author

timokau commented Feb 23, 2018

This package is just a never ending source of fun (please somebody stop me next time before I take on such a project 😬).

Do you have a build log for the failed one?

@vcunat
Copy link
Member

vcunat commented Feb 23, 2018 •
edited

Not anymore. It was probably not interesting – a compiler segfaulting or similar, as it sometimes happens with my (probably) buggy CPU.

@7c6f434c
Copy link
Member

@timokau if #23842 (comment) was not enough to stop you (or if you start fixing huge packages without checking their track record), then I am not sure stopping you is feasible…

@timokau timokau deleted the sage-fortran branch February 23, 2018 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timokau @Mic92 @GrahamcOfBorg @vcunat @7c6f434c