@GrahamcOfBorg test nginx

Success on x86_64-linux (full log)

syncing
webserver: running command: sync
webserver# [    8.165974] dhcpcd[781]: eth0: soliciting an IPv6 router
webserver: exit status 0
test script finished in 9.13s
cleaning up
killing webserver (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-nginx.drv-0/vde1.ctl': Directory not empty
/nix/store/rgn11hzfg47r61lgx1l63fs5d272r3z5-vm-test-run-nginx

Success on aarch64-linux (full log)

webserver: exit status 1
syncing
webserver: running command: sync
webserver: exit status 0
test script finished in 17.67s
cleaning up
killing webserver (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/fmv3v3gjzli3zacza0dyg0i9jrgk34z9-vm-test-run-nginx

Very cool!

Could we add an option for it so it can be turned off?

I want to use it myself, but I know that others (e362a3d#commitcomment-20787179) would like to not have to hard-depend on Python for changing nginx configs.

Maybe make it opt-in? Everybody who cares about it, can temporary turn it on or leave it on all the time.

I've added an option.

I'd prefer to not default it to false, as anyone attempting to debug their nginx configs is unlikely to guess that the option exists, given that most other NixOS config files don't have this functionality.

(Which is a problem in itself, but not in scope of this PR.)

@GrahamcOfBorg test nginx

Success on x86_64-linux (full log)

webserver: running command: sync
webserver# [  OK  ] Listening on Load/Save RF Kill Switch Status /dev/rfkill Watch.
webserver# [    5.383236] input: ImExPS/2 Generic Explorer Mouse as /devices/platform/i8042/serio1/input/input4
webserver: exit status 0
test script finished in 6.12s
cleaning up
killing webserver (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/7aww8iip618n3arzlaicg9zvwpwmgnki-vm-test-run-nginx

Success on aarch64-linux (full log)

webserver: exit status 1
syncing
webserver: running command: sync
webserver: exit status 0
test script finished in 17.96s
cleaning up
killing webserver (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/vqbpglkrynbzh0xilj8vfhhww7200dzn-vm-test-run-nginx

@Baughn ok. In the unlikely case of bugs in the formatter, it could then at least be disabled.

I'm really not in favor of this. Both pulling in python and having a new option sound like bad solutions to the problem. When we are the ones who generate such a crippled Nix file, we should also be responsible for fixing it!

The solution I'm proposing is to generate the file in a way similar to what I've done in #45470. That is, having a config option with a type of a nix value representing the configuration file in a reasonable way, then converting this to a list of lines and concatenate them all.

As a side effect this has the advantage that users are able to override default settings easily. A slight problem with this is that verbatim options can't be formatted this way, but if such a config option exists, users may not even need many verbatim options anymore anyways. Also it's a great integration into the module system with almost no cost.

As an example, this is how the start of the config as specified in nginx/default.nix could look like:

{
  config = {
    user = "${cfg.user} ${cfg.group}";
    error_log = cfg.logError;
    daemon = false;
    
    # No need for null check, null values automatically have no effect
    events = cfg.eventsConfig;
    
    http = mkIf cfg.recommendedOptimisation {
      sendfile = true;
      tcp_nopush = true;
      tcp_nodelay = true;
      keepalive_timeout = 65;
      types_hash_max_size = 2048;
    } // {
      # A list generates a key-value entry for every element
      include = [
        "${cfg.package}/conf/mime.types"
        "${cfg.package}/conf/fastcgi.conf"
        "${cfg.package}/conf/uwsgi_params"
      ];
      resolver = mkIf (cfg.resolver.addresses != [])
        "${toString cfg.resolver.addresses} ${optionalString (cfg.resolver.valid != "") "valid=${cfg.resolver.valid}"}";
      
      ssl_protocols = cfg.sslProtocols;
    };
  };
}

Maybe this should be closed as #57979 was merged?