Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eprover: fix build in non-GCC environments #34986

Merged
merged 1 commit into from Feb 14, 2018
Merged

eprover: fix build in non-GCC environments #34986

merged 1 commit into from Feb 14, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 14, 2018

Motivation for this change

eprover does not build on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vbgl vbgl added 0.kind: bug 6.topic: darwin Running or building packages on Darwin labels Feb 14, 2018
@GrahamcOfBorg GrahamcOfBorg removed the 6.topic: darwin Running or building packages on Darwin label Feb 14, 2018
@7c6f434c
Copy link
Member

@GrahamcOfBorg build eprover

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/bin/ekb_ginsert
shrinking /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/bin/ekb_insert
gzipping man pages under /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/bin
patching script interpreter paths in /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0
/nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/bin/eproof: interpreter directive changed from "/bin/bash -f" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/bash -f"
/nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/bin/eproof_ram: interpreter directive changed from "/bin/bash -f" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/bash -f"
checking for references to /build in /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0...
/nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

sh -c 'development_tools/e_install DOC/man/ekb_ginsert.1  /nix/store/w51rnlxvg3zrynrcr3znm5w7zkvs1x0b-eprover-2.0/share/man'
sh -c 'development_tools/e_install DOC/man/ekb_insert.1   /nix/store/w51rnlxvg3zrynrcr3znm5w7zkvs1x0b-eprover-2.0/share/man'
post-installation fixup
gzipping man pages under /nix/store/w51rnlxvg3zrynrcr3znm5w7zkvs1x0b-eprover-2.0/share/man/
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/w51rnlxvg3zrynrcr3znm5w7zkvs1x0b-eprover-2.0/bin
patching script interpreter paths in /nix/store/w51rnlxvg3zrynrcr3znm5w7zkvs1x0b-eprover-2.0
/nix/store/w51rnlxvg3zrynrcr3znm5w7zkvs1x0b-eprover-2.0/bin/eproof: interpreter directive changed from "/bin/bash -f" to "/nix/store/s8mff1kmnc63b21ybdid2ni0fw7mzy7r-bash-4.4-p12/bin/bash -f"
/nix/store/w51rnlxvg3zrynrcr3znm5w7zkvs1x0b-eprover-2.0/bin/eproof_ram: interpreter directive changed from "/bin/bash -f" to "/nix/store/s8mff1kmnc63b21ybdid2ni0fw7mzy7r-bash-4.4-p12/bin/bash -f"
/nix/store/w51rnlxvg3zrynrcr3znm5w7zkvs1x0b-eprover-2.0

7c6f434c
7c6f434c approved these changes Feb 14, 2018
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically the line in the preConfigure did nothing? Good catch.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/knyaxsvik9w3wikpkmd4850gpjg0hahd-eprover-2.0/bin/epclextract
shrinking /nix/store/knyaxsvik9w3wikpkmd4850gpjg0hahd-eprover-2.0/bin/eprover
gzipping man pages under /nix/store/knyaxsvik9w3wikpkmd4850gpjg0hahd-eprover-2.0/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/knyaxsvik9w3wikpkmd4850gpjg0hahd-eprover-2.0/bin
patching script interpreter paths in /nix/store/knyaxsvik9w3wikpkmd4850gpjg0hahd-eprover-2.0
/nix/store/knyaxsvik9w3wikpkmd4850gpjg0hahd-eprover-2.0/bin/eproof_ram: interpreter directive changed from "/bin/bash -f" to "/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/bash -f"
/nix/store/knyaxsvik9w3wikpkmd4850gpjg0hahd-eprover-2.0/bin/eproof: interpreter directive changed from "/bin/bash -f" to "/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/bash -f"
checking for references to /build in /nix/store/knyaxsvik9w3wikpkmd4850gpjg0hahd-eprover-2.0...
/nix/store/knyaxsvik9w3wikpkmd4850gpjg0hahd-eprover-2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/knyaxsvik9w3wikpkmd4850gpjg0hahd-eprover-2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/bin/e_deduction_server
shrinking /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/bin/eprover
gzipping man pages under /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/bin 
patching script interpreter paths in /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0
/nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/bin/eproof: interpreter directive changed from "/bin/bash -f" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/bash -f"
/nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0/bin/eproof_ram: interpreter directive changed from "/bin/bash -f" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/bash -f"
checking for references to /tmp/nix-build-eprover-2.0.drv-0 in /nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0...
/nix/store/4grzd7l2a6qxwxzgk84ngdg8p6piqifl-eprover-2.0

@7c6f434c 7c6f434c merged commit ca7b1e6 into NixOS:master Feb 14, 2018
@vbgl vbgl deleted the eprover-no-gcc branch February 14, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
0.kind: bug 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @7c6f434c @GrahamcOfBorg