pythonPackages.dkimpy: 0.6.2 -> 0.7.1 #34980

leenaars · 2018-02-14T21:54:05Z

Motivation for this change

Version bump of dkimpy with new dependency (authres) packaged.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda · 2018-02-14T22:12:16Z

pkgs/development/python-modules/authres/default.nix

+, pytest, dnspython, pynacl, authres }:
+
+buildPythonApplication rec {
+  name = "${pname}-${version}";


dotlambda · 2018-02-14T22:12:45Z

pkgs/development/python-modules/dkimpy/default.nix

@@ -1,20 +1,20 @@
 { stdenv, fetchurl, openssl, makeWrapper, buildPythonApplication
-, pytest, dnspython }:
+, pytest, dnspython, pynacl, authres, python }:

 buildPythonApplication rec {
  name = "${pname}-${version}";


Please get rid of name. It is not needed any more.

dotlambda · 2018-02-14T22:19:46Z

pkgs/development/python-modules/dkimpy/default.nix

+    for f in $out/bin/*; do
+      wrapProgram $f --prefix PYTHONPATH ":" $out/${python.sitePackages}/
+    done
+    popd


Why were these executables renamed in the first place? Is this done in other distributions too?

@dotlambda: The man pages refer to dkimverify etc, so that is the rationale...

dotlambda · 2018-02-14T22:21:09Z

pkgs/development/python-modules/authres/default.nix

+      Authenticated Recieved Chain (ARC) (draft-ietf-dmarc-arc-protocol-08)
+'';
+    homepage = https://launchpad.net/authentication-results-python;
+    license = licenses.apl2;


licenses.asl20

leenaars · 2018-02-15T15:19:27Z

All comments processed.

dotlambda · 2018-02-16T11:18:12Z

pkgs/development/python-modules/authres/default.nix

+    sha256 = "1crdff9wa4cma6p4a6ldiffa6c3awxafnv4d207h6z6msc3jb868";
+  };
+
+  buildInputs = [ pytest ];


checkInputs?

I had not come across that, but that is completely logical.

dotlambda · 2018-02-16T11:18:32Z

pkgs/development/python-modules/dkimpy/default.nix

-    url = "https://launchpad.net/${pname}/${majorversion}/${majorversion}.${minorversion}/+download/${name}.tar.gz";
-    sha256 = "1hagz8qk0v4ijfbcdq4z28bpgr2mkpr498z76i1vam2d50chmakl";
+    url = "https://launchpad.net/${pname}/${majorversion}/${majorversion}.${minorversion}/+download/${pname}-${version}.tar.gz";
+    sha256 = "13ds5f4vvaq63hnrglficqjpgcfxhzpcbkxhj7gbp51qilh8gqqh";
  };

  buildInputs = [ pytest ];


checkInputs?

FRidh · 2018-02-18T15:56:47Z

pkgs/development/python-modules/authres/default.nix

+buildPythonApplication rec {
+  pname = "authres";
+  majorversion = "1.0";
+  minorversion = "1";


these two are not parameters of buildPythonApplication and thus best moved into a let ... in expression.

FRidh · 2018-02-18T15:56:59Z

pkgs/development/python-modules/dkimpy/default.nix

-  majorversion = "0.6";
-  minorversion = "2";
+  majorversion = "0.7";
+  minorversion = "0";


leenaars · 2018-02-18T20:42:20Z

Moved version numbers to let statements for both packages.

dotlambda · 2018-02-22T10:01:16Z

pkgs/development/python-modules/dkimpy/default.nix

+let
+  majorversion = "0.7";
+  minorversion = "0";
+in

 buildPythonApplication rec {


Could you please change this to buildPythonPackage

dotlambda · 2018-02-22T10:03:06Z

pkgs/development/python-modules/authres/default.nix

+  minorversion = "1";
+in
+
+buildPythonApplication rec {


buildPythonPackage

dotlambda · 2018-02-22T10:03:46Z

pkgs/development/python-modules/authres/default.nix

+  pname = "authres";
+  version = "${majorversion}.${minorversion}";
+
+  src = fetchurl {


Please use fetchPypi if possible

dotlambda · 2018-02-22T10:04:08Z

pkgs/development/python-modules/authres/default.nix

+
+let
+  majorversion = "1.0";
+  minorversion = "1";


1.0.2 has been released: https://pypi.org/project/authres/

dotlambda · 2018-02-22T10:04:42Z

pkgs/development/python-modules/dkimpy/default.nix

  pname = "dkimpy";
-  majorversion = "0.6";
-  minorversion = "2";
  version = "${majorversion}.${minorversion}";

  src = fetchurl {


fetchPypi if possible

dotlambda · 2018-03-19T10:25:12Z

@leenaars Any progress?

leenaars · 2018-03-19T14:38:50Z

@dotlambda: I upgraded both packages to current version (very rapid pace) and made the rest of the modifications.

dotlambda

Please replace python test.py by ${python.interpreter} test.py.

dotlambda · 2018-03-19T15:11:22Z

pkgs/development/python-modules/dkimpy/default.nix

+    mv dkimverify.py dkimverify
+    mv dknewkey.py dknewkey
+    for f in $out/bin/*; do
+      wrapProgram $f --prefix PYTHONPATH ":" $out/${python.sitePackages}/


Is this wrapping necessary? The binaries should be wrapped by default.

I removed it.

dotlambda · 2018-03-19T15:14:00Z

pkgs/development/python-modules/authres/default.nix

+    sha256 = "1mcllhrwr23hwa2jn3m15k29ks1205ymwafjzchh8ma664hnzv6v";
+  };
+
+  checkInputs = [ pytest ];


Ran 0 tests in 0.000s

You might need to specify an appropriate checkPhase.

@leenaars It should be

checkInputs = [ ]; checkPhase = '' # run doctests python -m authres '';

I tried, but the checks are WIP. I cannot see how they should currently work. I suggest leaving as is.

Well, they work if you use what I wrote above.

leenaars · 2018-03-28T19:45:41Z

@dotlambda: All your suggestions processed. Anything else?

dotlambda · 2018-03-30T16:12:45Z

pkgs/development/python-modules/authres/default.nix

+      RFC 7293 The Require-Recipient-Valid-Since Header Field
+      RFC 7489 Domain-based Message Authentication, Reporting, and Conformance (DMARC)
+      Authenticated Recieved Chain (ARC) (draft-ietf-dmarc-arc-protocol-08)
+'';


indentation

dotlambda · 2018-03-30T16:14:43Z

@GrahamcOfBorg build python2.pkgs.dkimpy python3.pkgs.dkimpy

GrahamcOfBorg · 2018-03-30T16:16:19Z

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.dkimpy, python3.pkgs.dkimpy

Partial log (click to expand)

installing
/tmp/nix-build-python3.6-dkimpy-0.7.1.drv-0/dkimpy-0.7.1/dist /tmp/nix-build-python3.6-dkimpy-0.7.1.drv-0/dkimpy-0.7.1
Processing ./dkimpy-0.7.1-py3-none-any.whl
Installing collected packages: dkimpy
Successfully installed dkimpy-0.7.1
/tmp/nix-build-python3.6-dkimpy-0.7.1.drv-0/dkimpy-0.7.1
rm: missing operand
Try 'rm --help' for more information.
builder for ‘/nix/store/ps51wdk4z0sc8r6b16jkxya00jfll9g6-python3.6-dkimpy-0.7.1.drv’ failed with exit code 1
error: build of ‘/nix/store/ps51wdk4z0sc8r6b16jkxya00jfll9g6-python3.6-dkimpy-0.7.1.drv’ failed

GrahamcOfBorg · 2018-03-30T16:19:38Z

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.dkimpy, python3.pkgs.dkimpy

Partial log (click to expand)

installing
/build/dkimpy-0.7.1/dist /build/dkimpy-0.7.1
Processing ./dkimpy-0.7.1-py3-none-any.whl
Installing collected packages: dkimpy
Successfully installed dkimpy-0.7.1
/build/dkimpy-0.7.1
rm: missing operand
Try 'rm --help' for more information.
builder for '/nix/store/rgvss9zla4rcnn2fnhqvnvks107af778-python3.6-dkimpy-0.7.1.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/rgvss9zla4rcnn2fnhqvnvks107af778-python3.6-dkimpy-0.7.1.drv' failed

dotlambda · 2018-07-08T13:28:03Z

Closing in favor of #43219.

leenaars requested a review from FRidh as a code owner February 14, 2018 21:54

GrahamcOfBorg added the 6.topic: python label Feb 14, 2018

dotlambda reviewed Feb 14, 2018

View reviewed changes

leenaars force-pushed the dkimpy-0.7 branch from c5c746f to bc2559a Compare February 15, 2018 15:16

leenaars force-pushed the dkimpy-0.7 branch 2 times, most recently from 8f70a17 to c4915c5 Compare February 15, 2018 16:06

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 15, 2018

dotlambda reviewed Feb 16, 2018

View reviewed changes

leenaars force-pushed the dkimpy-0.7 branch 2 times, most recently from 4548bb8 to 58cf8e2 Compare February 17, 2018 11:30

FRidh requested changes Feb 18, 2018

View reviewed changes

leenaars force-pushed the dkimpy-0.7 branch from 58cf8e2 to e5bd0aa Compare February 18, 2018 20:41

dotlambda requested changes Feb 22, 2018

View reviewed changes

FRidh added the 2.status: work-in-progress label Feb 22, 2018

leenaars force-pushed the dkimpy-0.7 branch from e5bd0aa to 5f0a5a4 Compare March 19, 2018 14:24

leenaars changed the title ~~pythonPackages.dkimpy: 0.6.2 -> 0.7.0~~ pythonPackages.dkimpy: 0.6.2 -> 0.7.1 Mar 19, 2018

dotlambda requested changes Mar 19, 2018

View reviewed changes

leenaars force-pushed the dkimpy-0.7 branch from 5f0a5a4 to c3adf99 Compare March 20, 2018 21:22

leenaars added 2 commits March 21, 2018 00:38

pythonPackages.authres: init at 1.1.0

b8b204f

pythonPackages.dkimpy: 0.6.2 -> 0.7.1

622a3df

leenaars force-pushed the dkimpy-0.7 branch from c3adf99 to 622a3df Compare March 20, 2018 23:41

dotlambda requested changes Mar 30, 2018

View reviewed changes

dotlambda mentioned this pull request Jul 8, 2018

pythonPackages.dkimpy: 0.6.2 -> 0.8.1 #43219

Merged

9 tasks

dotlambda closed this Jul 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.dkimpy: 0.6.2 -> 0.7.1 #34980

pythonPackages.dkimpy: 0.6.2 -> 0.7.1 #34980

leenaars commented Feb 14, 2018

dotlambda Feb 14, 2018

dotlambda Feb 14, 2018

dotlambda Feb 14, 2018

leenaars Feb 15, 2018

dotlambda Feb 14, 2018

leenaars commented Feb 15, 2018

dotlambda Feb 16, 2018

leenaars Feb 17, 2018

dotlambda Feb 16, 2018

FRidh Feb 18, 2018

FRidh Feb 18, 2018

leenaars commented Feb 18, 2018

dotlambda Feb 22, 2018

dotlambda Feb 22, 2018

dotlambda Feb 22, 2018

dotlambda Feb 22, 2018

dotlambda Feb 22, 2018

dotlambda commented Mar 19, 2018

leenaars commented Mar 19, 2018

dotlambda left a comment

dotlambda Mar 19, 2018

leenaars Mar 20, 2018

dotlambda Mar 19, 2018

dotlambda Mar 20, 2018

leenaars Mar 20, 2018

dotlambda Mar 20, 2018

leenaars commented Mar 28, 2018

dotlambda Mar 30, 2018

dotlambda commented Mar 30, 2018

GrahamcOfBorg commented Mar 30, 2018

GrahamcOfBorg commented Mar 30, 2018

dotlambda commented Jul 8, 2018

pythonPackages.dkimpy: 0.6.2 -> 0.7.1 #34980

pythonPackages.dkimpy: 0.6.2 -> 0.7.1 #34980

Conversation

leenaars commented Feb 14, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leenaars commented Feb 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leenaars commented Feb 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Mar 19, 2018

leenaars commented Mar 19, 2018

dotlambda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leenaars commented Mar 28, 2018

Choose a reason for hiding this comment

dotlambda commented Mar 30, 2018

GrahamcOfBorg commented Mar 30, 2018

GrahamcOfBorg commented Mar 30, 2018

dotlambda commented Jul 8, 2018