stubby: init at 0.2.1 #34975
Merged
stubby: init at 0.2.1 #34975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't be built on macOS because of #34989. |
vcunat
reviewed
Feb 15, 2018
| queries sent from a client machine (desktop or laptop) to a DNS | ||
| Privacy resolver increasing end user privacy. Stubby is developed by | ||
| the getdns team. | ||
| ''; |
There was a problem hiding this comment.
Indentation, please, just as it was for getdns in the end https://github.com/NixOS/nixpkgs/pull/34921/files#diff-3f19f5b14f3dc0b7cdf83623bc28eb3cR25
|
Where is stubby and why is 6ec8fe0 pointing to my commit instead? |
|
I didnt merge this... |
|
w00t? |
|
@leenaars please tell me, you have closed this pull request at least. |
leenaars force-pushed the leenaars:stubby branch from 282b2b5 to 6ec8fe0 13 days ago
I think this might have triggered an automatic merging of the pull request, which is how people merge pull requests using the command line.
The logic to automatically merge a Pull Request looks at the commit SHA's present on the Pull Request.
If all of the commit SHA's have been pushed to the base branch already, we'll automatically mark it as merged.
Would it be the case that commits that are already present in the base branch NixOS:master were force pushed to the head branch leenaars:stubby, therefore producing what we see now?``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Stubby is a local stub resolver that implements RFC 7858, aka DNS-over-TLS. This allow private DNS requests.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)