Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding @0x4A6F to maintainers.nix #34984

Merged
merged 3 commits into from Feb 15, 2018
Merged

Adding @0x4A6F to maintainers.nix #34984

merged 3 commits into from Feb 15, 2018

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Feb 14, 2018

Motivation for this change

Trying to add my handle @0x4A6F to maintainers, to contribute to nixpkgs.

Looking forward for inclusion of #34842.

Things done

Adding github handle starting with decimal to maintainers.nix, but this will break nix expression.
nix-repl lib/maintainers.nix

Welcome to Nix version 1.11.16. Type :? for help.

Loading ‘lib/maintainers.nix’...
error: syntax error, unexpected INT, at /home/user/repositories/github.com/0x4A6F/nixpkgs-origin/lib/maintainers.nix:10:3
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Feb 15, 2018

Though this case... "0x4A6F" = "...." could be used and then lib.maintainers."0x4A6F", but it wouldn't be very nice either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants