Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5: 5.10.0 -> 5.10.1 #34993

Merged
merged 1 commit into from Feb 25, 2018
Merged

qt5: 5.10.0 -> 5.10.1 #34993

merged 1 commit into from Feb 25, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Feb 15, 2018 •
edited

Motivation for this change

Yeah, a bug fix release.

It currently still compiles, but it looks good.

@ttuegel @adisbladis @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bkchr bkchr requested a review from ttuegel as a code owner February 15, 2018 07:56
@bkchr
Copy link
Contributor Author

bkchr commented Feb 15, 2018

Hmm, somehow the kde activity manager wants to mix qt libraries. I will need to investigate what is happening there.

@bkchr
Copy link
Contributor Author

bkchr commented Feb 16, 2018

Okay, works now. I had some software in my user environment, sounds like: #30551

@bkchr
Copy link
Contributor Author

bkchr commented Feb 19, 2018

@adisbladis @peterhoeg did someone of you tried this?

@peterhoeg
Copy link
Member

I have not, no. And realistically won't these next few days.

@bkchr
Copy link
Contributor Author

bkchr commented Feb 25, 2018

ping @adisbladis @ttuegel

@adisbladis
Copy link
Member

I've been using this for the past few days :) Thanks!

@adisbladis adisbladis merged commit 0e086dd into NixOS:master Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bkchr @peterhoeg @adisbladis @matthewbauer @GrahamcOfBorg