Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinentry: add option to enable pinentry-emacs #34982

Merged
merged 1 commit into from Mar 19, 2018
Merged

pinentry: add option to enable pinentry-emacs #34982

merged 1 commit into from Mar 19, 2018

Conversation

tadfisher
Copy link
Contributor

Motivation for this change

I would like to easily build pinentry-emacs and use it as my preferred pinentry program for gpg-agent.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Note: nox test failed due to an issue in python-gnupg:

======================================================================
ERROR: test_filenames_with_spaces (test_gnupg.GPGTestCase)
Test that filenames with spaces are correctly handled
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-python2.7-python-gnupg-0.4.1.drv-0/python-gnupg-0.4.1/test_gnupg.py", line 758, in test_filenames_with_spaces
    self.do_file_encryption_and_decryption(encfname, decfname)
  File "/tmp/nix-build-python2.7-python-gnupg-0.4.1.drv-0/python-gnupg-0.4.1/test_gnupg.py", line 705, in do_file_encryption_and_decryption
    armor=False, output=encfname)
  File "/tmp/nix-build-python2.7-python-gnupg-0.4.1.drv-0/python-gnupg-0.4.1/gnupg.py", line 1372, in encrypt_file
    raise ValueError('No recipients specified with asymmetric '
ValueError: No recipients specified with asymmetric encryption

----------------------------------------------------------------------
Ran 21 tests in 63.728s

I don't believe the failure is related to this change.

@srhb
Copy link
Contributor

srhb commented Feb 18, 2018

Is there a good reason not to rely on an actual emacs but just a dummy flag? This appears to need external dependency handling, which seems a bit meh.

@tadfisher
Copy link
Contributor Author

Sure, I can make the flag just a check for the emacs package. For non-NixOS, though, this will make it difficult to enable while using an externally-installed emacs. Is there precedent here?

@srhb
Copy link
Contributor

srhb commented Feb 19, 2018

You're probably right, it doesn't win much. I don't know of anything like this in nixpkgs, so I'm unsure how to handle it.

fpletz
fpletz approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature requires no external dependency so the flag LGTM.

@matthewbauer matthewbauer changed the base branch from master to staging March 19, 2018 20:34
@matthewbauer matthewbauer merged commit 35ebf5b into NixOS:staging Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tadfisher @srhb @fpletz @matthewbauer @GrahamcOfBorg