Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devpi-server: 4.3.1 -> 4.4.0 #34983

Merged
merged 2 commits into from Feb 21, 2018
Merged

devpi-server: 4.3.1 -> 4.4.0 #34983

merged 2 commits into from Feb 21, 2018

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Feb 14, 2018

We also disable 3 tests because they are failing with pytest 3.4.0.
I don't why they are failing since we switch to pytest 3.4.0 but if I rollback pytest to 3.3.2, tests are ok.

Motivation for this change

Fix the build failure
https://hydra.nixos.org/build/68801588#tabs-summary

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
devpi-server: 4.3.1 -> 4.4.0
ad81cee 
We also disable 3 tests because they are failing with pytest 3.4.0.
@nlewo
Copy link
Member Author

nlewo commented Feb 14, 2018

cc @makefu

@nlewo
Copy link
Member Author

nlewo commented Feb 14, 2018

@GrahamcOfBorg build devpi-server

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

XFAIL test_views.py::TestStatusInfoPlugin::()::test_no_master_update
  sometimes fail due to race condition in db table creation
XPASS test_keyfs.py::TestSubscriber::()::test_persistent test monkeypatching wrong thing after refactoring
XPASS test_streaming.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_nginx.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_replica.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_replica_nginx.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux

============== 757 passed, 3 xfailed, 5 xpassed in 501.23 seconds ==============
/nix/store/2knlddx6rajcfhhhbmlvwfdnbsp5514h-devpi-server-4.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

  sometimes fail due to race condition in db table creation
XPASS test_keyfs.py::TestSubscriber::()::test_persistent test monkeypatching wrong thing after refactoring
XPASS test_streaming.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_nginx.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_replica.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_replica_nginx.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_views.py::TestStatusInfoPlugin::()::test_no_issue_replica sometimes fail due to race condition in db table creation

============== 757 passed, 2 xfailed, 6 xpassed in 912.54 seconds ==============
/nix/store/gcgwd5w1wf76qhywwjah6qhpygxig9rf-devpi-server-4.4.0

makefu
makefu approved these changes Feb 14, 2018
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested executable, looks good!

@davidak
Copy link
Member

davidak commented Feb 15, 2018

Build fails on debian 9 and OS X 10.10.5: https://pastebin.com/W8PThrrv

@nlewo
Copy link
Member Author

nlewo commented Feb 15, 2018

Thanks @davidak !
@GrahamcOfBorg build devpi-client

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

2018-02-15 07:45:31,372 DEBUG [NOTI] waiting for tx-serial 178
=============================== warnings summary ===============================
None
  Module already imported so cannot be rewritten: _pytest.pytester

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 1 tests deselected ==============================
= 1 failed, 181 passed, 2 skipped, 1 deselected, 1 warnings in 161.66 seconds ==
builder for '/nix/store/11lz20k93fck18k1vlpyixh2cjjfcsm2-devpi-client-3.1.0.drv' failed with exit code 1
error: build of '/nix/store/11lz20k93fck18k1vlpyixh2cjjfcsm2-devpi-client-3.1.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

2018-02-15 07:55:48,042 DEBUG [NOTI] waiting for tx-serial 178
=============================== warnings summary ===============================
None
  Module already imported so cannot be rewritten: _pytest.pytester

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 1 tests deselected ==============================
= 1 failed, 181 passed, 2 skipped, 1 deselected, 1 warnings in 720.87 seconds ==
builder for '/nix/store/a0xmnc9chy5pimvkk2j5m6pmg48kc3zz-devpi-client-3.1.0.drv' failed with exit code 1
error: build of '/nix/store/a0xmnc9chy5pimvkk2j5m6pmg48kc3zz-devpi-client-3.1.0.drv' failed

@Mic92
Copy link
Member

Mic92 commented Feb 15, 2018

@GrahamcOfBorg build devpi-server

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/2knlddx6rajcfhhhbmlvwfdnbsp5514h-devpi-server-4.4.0

@Mic92
Copy link
Member

Mic92 commented Feb 15, 2018

I think the tests fail because 404, the number, does not longer match <Response [404]>, the object.
These are minor bugs, I would disable those tests using pytest -k option (see nixpkgs for examples) and report those upstream.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

  sometimes fail due to race condition in db table creation
XPASS test_keyfs.py::TestSubscriber::()::test_persistent test monkeypatching wrong thing after refactoring
XPASS test_streaming.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_nginx.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_replica.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_replica_nginx.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_views.py::TestStatusInfoPlugin::()::test_no_issue_replica sometimes fail due to race condition in db table creation

============== 757 passed, 2 xfailed, 6 xpassed in 204.29 seconds ==============
/nix/store/jz3dakrfg7v9dcmk4s01n6jry48q1n4h-devpi-server-4.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

XPASS test_keyfs.py::TestSubscriber::()::test_persistent test monkeypatching wrong thing after refactoring
XPASS test_streaming.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_nginx.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_replica.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_streaming_replica_nginx.py::test_streaming_differing_content_size[2-1.2] nginx 1.4 on linux
XPASS test_views.py::TestStatusInfoPlugin::()::test_no_issue_replica sometimes fail due to race condition in db table creation
XPASS test_views.py::TestStatusInfoPlugin::()::test_no_master_update sometimes fail due to race condition in db table creation

============== 757 passed, 1 xfailed, 7 xpassed in 220.59 seconds ==============
/nix/store/gcgwd5w1wf76qhywwjah6qhpygxig9rf-devpi-server-4.4.0

@nlewo
Copy link
Member Author

nlewo commented Feb 15, 2018

I've tryied to upgrade devpi-client but it fails on more tests. Since my initial objective was to fix devpi-server, I didn't try hard to upgrade the client...

@GrahamcOfBorg build devpi-client

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

SKIP [1] testing/test_main.py:57: condition: sys.version_info < (3,)

=============================== warnings summary ===============================
None
  Module already imported so cannot be rewritten: _pytest.pytester

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 2 tests deselected ==============================
====== 181 passed, 2 skipped, 2 deselected, 1 warnings in 166.75 seconds =======
/nix/store/hygdlwscc1adbfghr430dckkqrf5l2ys-devpi-client-3.1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

SKIP [1] testing/test_main.py:57: condition: sys.version_info < (3,)

=============================== warnings summary ===============================
None
  Module already imported so cannot be rewritten: _pytest.pytester

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 2 tests deselected ==============================
====== 181 passed, 2 skipped, 2 deselected, 1 warnings in 718.71 seconds =======
/nix/store/2bsc9kdvzhymaw3ii2vg4aiz70qcqbd8-devpi-client-3.1.0

@nlewo
Copy link
Member Author

nlewo commented Feb 21, 2018

@GrahamcOfBorg build devpi-client devpi-server

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)


=============================== warnings summary ===============================
None
  Module already imported so cannot be rewritten: _pytest.pytester

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 2 tests deselected ==============================
====== 181 passed, 2 skipped, 2 deselected, 1 warnings in 157.33 seconds =======
/nix/store/k3sjm4c40ckmqsfygcn7zbp09y79b312-devpi-client-3.1.0
/nix/store/rd3q6g74b2z8pnld7vwc6in31c9xhdd1-devpi-server-4.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)


=============================== warnings summary ===============================
None
  Module already imported so cannot be rewritten: _pytest.pytester

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 2 tests deselected ==============================
====== 181 passed, 2 skipped, 2 deselected, 1 warnings in 1002.52 seconds ======
/nix/store/r04wiz0ynmhfm23ls9p1bamak3hphbq6-devpi-client-3.1.0
/nix/store/1bdf74qc1qc2igd8s15klxmshzzkfzgp-devpi-server-4.4.0

@nlewo nlewo merged commit 4f7650b into NixOS:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu makefu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nlewo @GrahamcOfBorg @davidak @Mic92 @makefu