PICARD-1192: Add .txt extension in path if no extension is there #837
Conversation
vishichoudhary
changed the title
| @@ -248,6 +248,8 @@ def _save_log_as_do(self): | |||
| filter=_("Text Files (*.txt *.TXT)"), | |||
| options=QtWidgets.QFileDialog.DontConfirmOverwrite | |||
| ) | |||
| if not path.endswith('.txt') and not path.endswith('.TXT'): | |||
| path = path + '.txt' | |||
There was a problem hiding this comment.
Not necessarily wanted behaviour. Logs may also be stored with a different extension like picard.log or even without an extension.
There was a problem hiding this comment.
Although I am not entirely sure the intentions with which this feature was implemented since there is a text file filter above. @zas any thoughts?
There was a problem hiding this comment.
@samj1912 i don't know why this happens. This was a small fix. Though what i found interesting is that write operation gives output False if you havn't specifiy any extension
There was a problem hiding this comment.
Hmmm, imho we should remove filter=_("Text Files (*.txt *.TXT)"), this is why it fails if none of those extensions is set.
There was a problem hiding this comment.
@zas removing the filter doesn't seem to have any effect on it. Let me just check the reason behind this behaviour.
Summary
Problem
Currently if you click on save as option in log dialog. And if you doesn't specify .txt or .TXT format it will not save that file
Solution
I simply check the file and if there isn't any .txt or .TXT extension add '.txt' extension
Action