getdns: init -> 1.3.0 #34910
getdns: init -> 1.3.0 #34910
Conversation
|
|
||
| nativeBuildInputs = [ libtool m4 libbsd ]; | ||
|
|
||
| buildInputs = [ unbound libidn openssl doxygen autoreconfHook |
There was a problem hiding this comment.
autoreconfHook, automake and file also belongs in nativeBuildInputs.
There was a problem hiding this comment.
I believe doxygen is a build-time only dependency as well.
|
I would prefer |
|
|
||
| nativeBuildInputs = [ libtool m4 libbsd ]; | ||
|
|
||
| buildInputs = [ unbound libidn openssl doxygen autoreconfHook |
There was a problem hiding this comment.
I believe doxygen is a build-time only dependency as well.
| buildInputs = [ unbound libidn openssl doxygen autoreconfHook | ||
| automake file check ]; | ||
|
|
||
| patchPhase = ''substituteInPlace m4/acx_openssl.m4 \ |
There was a problem hiding this comment.
Format it like this:
patchPhase = ''
substituteInPlace m4/acx_openssl.m4 \
--replace /usr/local/ssl ${openssl.dev}
'';
| meta = with stdenv.lib; { | ||
| description = "A modern asynchronous DNS API"; | ||
| longDescription = '' | ||
| getdns is an implementation of a modern asynchronous DNS API; the |
There was a problem hiding this comment.
You can safely indent the description inside '' quote.
| inspire application developers to implement innovative security | ||
| solutions in their applications. | ||
| ''; | ||
| homepage = "https://getdnsapi.net"; |
There was a problem hiding this comment.
Use
homepage = https://getdnsapi.net;
(URL is a first-class type in Nix.)
|
All comments processed. |
|
@leenaars I dont think you meant to close this? |
|
GitHub PRs are updated via (force-)pushing the branch from which they're filed. |
|
@adisbladis: I thought someone merged (it says: "Pull request successfully merged and closed"). I'll submit another pull request. Thanks for the alert. Update: I submitted #34921. |
Motivation for this change
This is a very useful library that provides an abstraction of DNS to application developers.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)