Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph-easy: init at 0.76 #34903

Merged
merged 1 commit into from Feb 15, 2018
Merged

graph-easy: init at 0.76 #34903

merged 1 commit into from Feb 15, 2018

Conversation

jensbin
Copy link
Contributor

@jensbin jensbin commented Feb 12, 2018

Motivation for this change

graph-easy is a small tools which converts between graph formats and layout/render graphs.

It also helps to create handy ASCII graphs:

$ echo "[ Bonn ] -- car --> [ Berlin ], [ Ulm ]" | graph-easy

        +--------+  car   +-----+
        |  Bonn  | -----> | Ulm |
        +--------+        +-----+
          |
          | car
          v
        +--------+
        | Berlin |
        +--------+
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

joachifm
joachifm reviewed Feb 13, 2018
View reviewed changes
pkgs/tools/misc/graph-easy/default.nix Outdated

meta = with stdenv.lib; {
homepage = http://search.cpan.org/~tels/Graph-Easy/bin/graph-easy;
description = "render/convert graphs in/from various formats";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capitalize description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.
Other question, should this package move to pkgs/tools/graphics ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think it's appropriate to move it, sure; I think you're better suited to judge that than I am in any case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it over to tools/graphics. Makes more sense.

@joachifm joachifm merged commit 34fa5d2 into NixOS:master Feb 15, 2018
@jensbin jensbin deleted the graph-easy_0.76 branch February 15, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jensbin @joachifm @GrahamcOfBorg