Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted parallel::{count|count_if} for Ranges TS (see #1668) #3169

Merged
merged 7 commits into from Feb 15, 2018

Conversation

cogle
Copy link
Contributor

@cogle cogle commented Feb 12, 2018

Extends the count and count_if algorithms for Ranges.

Proposed Changes

@hkaiser hkaiser added this to Open Tickets in Standard Algorithms via automation Feb 12, 2018
@hkaiser hkaiser added this to the 1.1.0 milestone Feb 12, 2018
@hkaiser hkaiser moved this from Open Tickets to Work in progress in Standard Algorithms Feb 12, 2018
@hkaiser
Copy link
Member

hkaiser commented Feb 12, 2018

@cogle could you please add the new files to the build system for the documentation as well (here: https://github.com/STEllAR-GROUP/hpx/blob/master/docs/CMakeLists.txt#L115) ?

@cogle
Copy link
Contributor Author

cogle commented Feb 13, 2018

It appears I failed the following test
docker run -v $PWD:/hpx -w /hpx ${IMAGE_NAME} ./build/bin/inspect --all --output=./build/hpx_inspect_report.html

Just wondering what may be the source of this failure may be.

@msimberg
Copy link
Contributor

inspect is a small tool that checks for things like formatting issues or missing includes. In your case it's complaining about trailing whitespace. You can see the report here. There are links at the bottom of the report to the offending lines.

In general this report should be available under artifacts on circleci, but you have to be signed in to see it.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@cogle
Copy link
Contributor Author

cogle commented Feb 13, 2018

@biddisco what are some possible reasons for failing the pycicle daint-clang-6.0.0 Test that I could look into?

@msimberg
Copy link
Contributor

@cogle Actually at the moment even we can't tell what went wrong in that one because the results are not viewable. Most likely the failed test is completely unrelated to your changes but once things are back to normal clicking on details should get you an idea of what's failed.

@cogle
Copy link
Contributor Author

cogle commented Feb 14, 2018

Ok thanks! I was wondering if I was like with circleci missing a way to view the results.

@msimberg msimberg merged commit d4e461f into STEllAR-GROUP:master Feb 15, 2018
Standard Algorithms automation moved this from Work in progress to Merged to master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Standard Algorithms
  
Merged to master
Development

Successfully merging this pull request may close these issues.

None yet

3 participants