Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: 1.8.3 -> 1.9.1 #34918

Merged
merged 1 commit into from Feb 13, 2018
Merged

grpc: 1.8.3 -> 1.9.1 #34918

merged 1 commit into from Feb 13, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 13, 2018

Motivation for this change

Updating to latest release, and adding metadata and license information.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

CC @shlevy

@bhipple
grpc: 1.8.3 -> 1.9.1
5371811 
Also added meta and license information.
bhipple
bhipple commented Feb 13, 2018
View reviewed changes
pkgs/development/libraries/grpc/default.nix
license = licenses.asl20;
homepage = https://grpc.io/;
};
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I formatted it to try to keep it consistent with what I've seen in most nixpkgs, but if this style is actually preferred/more common I can undo that.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/vzyv3j6cln3kkx19ba1h8k7n9d05ihzb-grpc-1.9.1/bin/grpc_cpp_plugin
shrinking /nix/store/vzyv3j6cln3kkx19ba1h8k7n9d05ihzb-grpc-1.9.1/bin/grpc_verify_jwt
shrinking /nix/store/vzyv3j6cln3kkx19ba1h8k7n9d05ihzb-grpc-1.9.1/bin/grpc_print_google_default_creds_token
shrinking /nix/store/vzyv3j6cln3kkx19ba1h8k7n9d05ihzb-grpc-1.9.1/bin/grpc_create_jwt
shrinking /nix/store/vzyv3j6cln3kkx19ba1h8k7n9d05ihzb-grpc-1.9.1/bin/check_epollexclusive
shrinking /nix/store/vzyv3j6cln3kkx19ba1h8k7n9d05ihzb-grpc-1.9.1/lib/libgrpc_csharp_ext.so
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vzyv3j6cln3kkx19ba1h8k7n9d05ihzb-grpc-1.9.1/lib  /nix/store/vzyv3j6cln3kkx19ba1h8k7n9d05ihzb-grpc-1.9.1/bin
patching script interpreter paths in /nix/store/vzyv3j6cln3kkx19ba1h8k7n9d05ihzb-grpc-1.9.1
checking for references to /build in /nix/store/vzyv3j6cln3kkx19ba1h8k7n9d05ihzb-grpc-1.9.1...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/7blvwps65g820ifw1gnfnhi1lgccpsk2-grpc-1.9.1/bin/gen_hpack_tables
shrinking /nix/store/7blvwps65g820ifw1gnfnhi1lgccpsk2-grpc-1.9.1/bin/grpc_objective_c_plugin
shrinking /nix/store/7blvwps65g820ifw1gnfnhi1lgccpsk2-grpc-1.9.1/bin/grpc_ruby_plugin
shrinking /nix/store/7blvwps65g820ifw1gnfnhi1lgccpsk2-grpc-1.9.1/bin/grpc_node_plugin
shrinking /nix/store/7blvwps65g820ifw1gnfnhi1lgccpsk2-grpc-1.9.1/bin/grpc_php_plugin
shrinking /nix/store/7blvwps65g820ifw1gnfnhi1lgccpsk2-grpc-1.9.1/lib/libgrpc_csharp_ext.so
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7blvwps65g820ifw1gnfnhi1lgccpsk2-grpc-1.9.1/lib  /nix/store/7blvwps65g820ifw1gnfnhi1lgccpsk2-grpc-1.9.1/bin 
patching script interpreter paths in /nix/store/7blvwps65g820ifw1gnfnhi1lgccpsk2-grpc-1.9.1
checking for references to /tmp/nix-build-grpc-1.9.1.drv-0 in /nix/store/7blvwps65g820ifw1gnfnhi1lgccpsk2-grpc-1.9.1...

@shlevy shlevy merged commit 5371811 into NixOS:master Feb 13, 2018
@bhipple bhipple deleted the grpc-upgrade branch February 24, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @GrahamcOfBorg @shlevy