buildRustCrate: add a postInstall hook #34906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmackenzie
changed the title
sjmackenzie
force-pushed
the
rust_build_crate_postinstall
branch
from
b9cbffd
to
8f579a2
Compare
sjmackenzie
changed the title
sjmackenzie
added a commit
to sjmackenzie/fractalide
that referenced
this pull request
Feb 12, 2018
Solution: once NixOS/nixpkgs#34906 gets merged then this code will work by passing in a postInstall phase which will be run by `runHook postInstall` at the end of the installPhase
sjmackenzie
added a commit
to sjmackenzie/fractalide
that referenced
this pull request
Feb 12, 2018
Solution: depends on NixOS/nixpkgs#34906 getting merged. This allows one to pass in this attribute: `postInstall = "ln -s $out/lib/*.so $out/lib/libagent.so";` Allowing for an indirection so the scheduler will always find a libagent.so to load.
|
@qknight could you take a look at this please? |
|
@sjmackenzie are there many packages in nixpkgs which use if so, do they all build? |
|
|
|
Thanks @qknight! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/explicit-runhook-in-derivation/4614/27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Need to add a SONAME for rust shared objects.
The simplest way is to add a postInstall phase which will allow me to do a
postInstall = "ln -s $out/lib/*.so $out/lib/libagent.so";Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)