Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icu: fix regression on 32bit, missing parens :) #36130

Merged
merged 1 commit into from Feb 28, 2018
Merged

icu: fix regression on 32bit, missing parens :) #36130

merged 1 commit into from Feb 28, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 28, 2018

Fixes #35850.

Fixes virtualbox test, or at least unblocks it :).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/582nyi1kj60mpyhzxn4zw9xrkhvkgawv-icu4c-59.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/zsv50qkm20w3an0fnb7kz8nl28dvha7f-icu4c-59.1

@Mic92
Copy link
Member

Mic92 commented Feb 28, 2018

@GrahamcOfBorg build teamviewer

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Package ‘teamviewer-12.0.85001’ in /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/pkgs/applications/networking/remote/teamviewer/default.nix:82 has an unfree license (‘unfree’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘teamviewer-12.0.85001’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/networking/remote/teamviewer/default.nix:82 has an unfree license (‘unfree’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 28, 2018

It's unfree, but teamviewer builds here 👍 (on x86_64-linux).

@GrahamcOfBorg test virtualbox

@dtzWill dtzWill merged commit b70e3f0 into NixOS:master Feb 28, 2018
@dtzWill dtzWill deleted the fix/icu-gcc6 branch February 28, 2018 16:24
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/5s42ancq2jhjy89lhsacwi49spk11lgn-icu4c-59.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘teamviewer-12.0.85001’ in /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/pkgs/applications/networking/remote/teamviewer/default.nix:82 has an unfree license (‘unfree’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

@dtzWill dtzWill mentioned this pull request Feb 28, 2018
Closed
8 tasks
@vcunat
Copy link
Member

vcunat commented Feb 28, 2018

🎉 This was blocking the channel, too. (i686 small ISO)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @Mic92 @vcunat