WIP: Updating android sdk and related tools to version 26. #36112
Conversation
My Android application based on the reflex-platform does not yet build with this changes. So please don't merge. I am just putting it here, because I won't get to finishing this for at least a few weeks, so others needing this, can more easily pick up the work, if needed. Also full disclaimer: I am an absolute noob when it comes to Android development, so if someone more involved can have a look at my changes - that would be great.
|
Hmm great initiative. I'm however have also started some attempts to package this new SDK concurrently, but I haven't published anything about it yet. Furthermore, there is something else you need to take into account -- the newer Android SDK's license has changed and mandates people to accept an EULA. This means that in Nixpkgs, we must prevent the SDK from being downloaded automatically because this violates the terms and conditions. |
Awesome! I am happy to assist!
That's kind of a bummer. How do we handle something like this in nix? We can't really package it then - right? |
|
@svanderburg do you have a solution for the EULA problem? Are there any other blockers? |
|
Other packages with license agreements work by requiring the user to specify some argument or config option. See sc2-headless, or maybe even androidenv.buildgradleapp. |
|
uh nice, thank you! |
|
Any updates on this pull request, please? |
There was a problem hiding this comment.
@eskimor Could you please consider closing this PR? Please find analysis below.
Based on PR title and quick review of PR content, I understand intention of this PR is to update Android-related dev tools to version 26. Based on current master branch, the changes of this PR are superseded.
In the comments of this PR in Oct 2018 there were concerns re license - e.g.:
Furthermore, there is something else you need to take into account -- the newer Android SDK's license has changed and mandates people to accept an EULA. This means that in Nixpkgs, we must prevent the SDK from being downloaded automatically because this violates the terms and conditions.
EULA-related changes were introduced in 2019 e.g. #54915 so the comments in this PR are superseded.
| @@ -148,4 +148,15 @@ in | |||
| }; | |||
| }; | |||
|
|
|||
| source_26 = buildSource { | |||
There was a problem hiding this comment.
Seems superseded in current master branch:
nixpkgs/pkgs/development/mobile/androidenv/generated/packages.nix
Lines 1840 to 1850 in d7a68e9
| @@ -12,12 +12,12 @@ let inherit (stdenv.lib) makeLibraryPath; in | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| name = "android-sdk-${version}"; | |||
| version = "25.2.5"; | |||
| version = "26.0.1"; | |||
There was a problem hiding this comment.
Seems superseded in current master branch:
nixpkgs/pkgs/development/mobile/androidenv/generated/packages.nix
Lines 1907 to 1920 in 4120419
|
Indeed, this is obsolete. |
My Android application based on the reflex-platform does not yet build with this
changes. So please don't merge. I am just putting it here, because I won't get
to finishing this for at least a few weeks, so others needing this, can more
easily pick up the work, if needed.
Also full disclaimer: I am an absolute noob when it comes to Android
development, so if someone more involved can have a look at my changes - that
would be great.
Motivation for this change
If you build an Android application requiring APIs like Foreground service, you need at least version 26 of the androidsdk to have it compile.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)