Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

searx: 0.13.1 -> 0.14.0 #36132

Merged
merged 1 commit into from Mar 1, 2018
Merged

searx: 0.13.1 -> 0.14.0 #36132

merged 1 commit into from Mar 1, 2018

Conversation

leenaars
Copy link
Contributor

Motivation for this change

Version bump. Note that tests are temporarily disabled because Geckodriver is broken (#35301).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

I think it makes more sense to wait until the geckodriver update is merged.

@globin
Copy link
Member

globin commented Mar 1, 2018

geckodriver is merged, please try enabling the tests again

@dotlambda
Copy link
Member

@GrahamcOfBorg build searx

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

test_request (tests.unit.engines.test_seedpeer.TestSeedPeerEngine) ... ok
test_response_raises_attr_error_on_empty_response (tests.unit.engines.test_seedpeer.TestSeedPeerEngine) ... ok
test_response_returns_all_results (tests.unit.engines.test_seedpeer.TestSeedPeerEngine) ... ok
test_response_returns_correct_results (tests.unit.engines.test_seedpeer.TestSeedPeerEngine) ... ok
test_response_returns_empty_list (tests.unit.engines.test_seedpeer.TestSeedPeerEngine) ... ok

----------------------------------------------------------------------
Ran 225 tests in 0.271s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

test_request (tests.unit.engines.test_arxiv.TestBaseEngine) ... ok
test_response (tests.unit.engines.test_arxiv.TestBaseEngine) ... ok
test_request (tests.unit.engines.test_archlinux.TestArchLinuxEngine) ... ok
test_response (tests.unit.engines.test_archlinux.TestArchLinuxEngine) ... ok

----------------------------------------------------------------------
Ran 225 tests in 1.420s

OK
/nix/store/kgq0p02v2k5g8gh3lwm0jfylyw9hxjx2-searx-0.14.0

@dotlambda
Copy link
Member

@leenaars Did you try if preCheck is still needed?

@leenaars
Copy link
Contributor Author

leenaars commented Mar 1, 2018

The preCheck part was there previously. I assumed it was there for a reason, so I didn't touch it...

@dotlambda
Copy link
Member

Please try removing it and check if the build fails.

@leenaars
Copy link
Contributor Author

leenaars commented Mar 1, 2018 •
edited

I did. That breaks the build. So that test has another (longer standing) issue, not related to the issue now fixed.

I will report upstream. However, this does not prevent the improved Searx in nixpkgs, I presume. Because it actually works beautifully, it is that particular test (which is one of many tests) that is broken somehow upstream...

So the closure should stay as is, and should be ready for merge.

@dotlambda dotlambda merged commit 31eb999 into NixOS:master Mar 1, 2018
@dotlambda
Copy link
Member

Feel free to open a PR once the issue with the tests has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leenaars @dotlambda @globin @GrahamcOfBorg