Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gawk: 4.2.0 -> 4.2.1 #36126

Merged
merged 1 commit into from Feb 28, 2018
Merged

gawk: 4.2.0 -> 4.2.1 #36126

merged 1 commit into from Feb 28, 2018

Conversation

mguentner
Copy link
Contributor

Motivation for this change

4.2.0 broke some stuff for me

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Feb 28, 2018

I think this belong into staging.

@mguentner
Copy link
Contributor Author

Should I rebase?

This triggers a mass rebuild, but besides that hopefully nothing breaks. Depending on when staging will be merged, this PR could also be merged into master prior to that.

@Mic92
Copy link
Member

Mic92 commented Feb 28, 2018

Yes, please. We don't want mass-rebuilds on master to avoid as slows down development.

@dtzWill
Copy link
Member

dtzWill commented Feb 28, 2018

Can you elaborate on what was broken in 4.2.0 that this fixes? Mostly just curious :).

@mguentner
Copy link
Contributor Author

@dtzWill see ethersex/ethersex#506

I did not try to find the actual bug, it seemed like a very (too) deep rabbit hole, so I stopped and inversed. 🐰 😸 🎩 🏃‍♀️

In short, to reproduce you have to do

git clone https://github.com/ethersex/ethersex
cd ethersex
nix-shell -p pkgconfig gcc git m4 gdb avrgcc avrlibc avrbinutils avrdude ncurses perl
make menuconfig

the result should be an ncurses interface similar to that one:

e6

@mguentner mguentner changed the base branch from master to staging February 28, 2018 23:27
@mguentner
Copy link
Contributor Author

✅ force pushed 🔥
✅ changed base
✅ shrewd up the review process
✅ confused @GrahamcOfBorg

@Ericson2314 Ericson2314 removed their request for review February 28, 2018 23:38
@Mic92
Copy link
Member

Mic92 commented Feb 28, 2018

@GrahamcOfBorg build gawk

please

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/qlknfciwpkilcx4ipvcavpnlw6c8fwhz-gawk-4.2.1/lib  /nix/store/qlknfciwpkilcx4ipvcavpnlw6c8fwhz-gawk-4.2.1/libexec  /nix/store/qlknfciwpkilcx4ipvcavpnlw6c8fwhz-gawk-4.2.1/bin 
checking for references to /tmp/nix-build-gawk-4.2.1.drv-0 in /nix/store/qlknfciwpkilcx4ipvcavpnlw6c8fwhz-gawk-4.2.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/y6347xvj6glvhfcqyrax8lgn0509bs8y-gawk-4.2.1-info
strip is /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/bin/strip
checking for references to /tmp/nix-build-gawk-4.2.1.drv-0 in /nix/store/y6347xvj6glvhfcqyrax8lgn0509bs8y-gawk-4.2.1-info...
shrinking RPATHs of ELF executables and libraries in /nix/store/6x3wlsnamr5w8kv7l2hjpk5azhxjw4f5-gawk-4.2.1-man
gzipping man pages under /nix/store/6x3wlsnamr5w8kv7l2hjpk5azhxjw4f5-gawk-4.2.1-man/share/man/
/nix/store/qlknfciwpkilcx4ipvcavpnlw6c8fwhz-gawk-4.2.1
strip is /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/bin/strip
checking for references to /tmp/nix-build-gawk-4.2.1.drv-0 in /nix/store/6x3wlsnamr5w8kv7l2hjpk5azhxjw4f5-gawk-4.2.1-man...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

post-installation fixup
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
stripping (with command strip and flags -S) in /nix/store/xvxdawxdlm6kl05sglybay02d2hpbp9f-gawk-4.2.1/lib  /nix/store/xvxdawxdlm6kl05sglybay02d2hpbp9f-gawk-4.2.1/libexec  /nix/store/xvxdawxdlm6kl05sglybay02d2hpbp9f-gawk-4.2.1/bin
patching script interpreter paths in /nix/store/xvxdawxdlm6kl05sglybay02d2hpbp9f-gawk-4.2.1
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
patching script interpreter paths in /nix/store/0s0ps34jgi4ryq76kpk6xs6rqw4gbli2-gawk-4.2.1-info
gzipping man pages under /nix/store/y1zbd5n23rl25kxlf5wk08an4kqbl2wm-gawk-4.2.1-man/share/man/
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
patching script interpreter paths in /nix/store/y1zbd5n23rl25kxlf5wk08an4kqbl2wm-gawk-4.2.1-man
/nix/store/xvxdawxdlm6kl05sglybay02d2hpbp9f-gawk-4.2.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/f8wbqvhbj0k0qgbj9gqqfr1976xzvq99-gawk-4.2.1/lib  /nix/store/f8wbqvhbj0k0qgbj9gqqfr1976xzvq99-gawk-4.2.1/libexec  /nix/store/f8wbqvhbj0k0qgbj9gqqfr1976xzvq99-gawk-4.2.1/bin
checking for references to /build in /nix/store/f8wbqvhbj0k0qgbj9gqqfr1976xzvq99-gawk-4.2.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/qm0qqvdd6izs3kw10s19lb5fix12f7qz-gawk-4.2.1-info
strip is /nix/store/gfgczbs0cy0blibb0acv39cayq7qbplg-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/qm0qqvdd6izs3kw10s19lb5fix12f7qz-gawk-4.2.1-info...
shrinking RPATHs of ELF executables and libraries in /nix/store/mkaxlj7q20kdnd90fyh69fc9z51isg6n-gawk-4.2.1-man
gzipping man pages under /nix/store/mkaxlj7q20kdnd90fyh69fc9z51isg6n-gawk-4.2.1-man/share/man/
strip is /nix/store/gfgczbs0cy0blibb0acv39cayq7qbplg-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/mkaxlj7q20kdnd90fyh69fc9z51isg6n-gawk-4.2.1-man...
/nix/store/f8wbqvhbj0k0qgbj9gqqfr1976xzvq99-gawk-4.2.1

@Mic92
Copy link
Member

Mic92 commented Feb 28, 2018

@GrahamcOfBorg eval

@Mic92 Mic92 merged commit fbd90af into NixOS:staging Feb 28, 2018
@mguentner mguentner deleted the gawk_4_2_0_to_4_2_1 branch February 28, 2018 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@orivej orivej Awaiting requested review from orivej

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: printing 6.topic: python 6.topic: qt/kde 8.has: module (update) 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mguentner @Mic92 @dtzWill @GrahamcOfBorg