Update message to reflect nix 2.0 availability of imperative nix-update #36123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
You are right, I should have added a dash in front as it does not apply to Nixos but to other operating systems nixpkgs can be used with. Fixed it, and added a suggestion how the user may find out which version of Nix he or she is using. (note to others: This is the message that gets printed when the Nix version is too old to evaluate it. The new nix command offers its own proper upgrade capability, so the user should be prompted to use that instead of other options.) |
leenaars
force-pushed
the
patch-1
branch
2 times, most recently
from
eb963af
to
8bd3137
Compare
FRidh
reviewed
Mar 4, 2018
default.nix
Outdated
| @@ -8,6 +8,9 @@ if ! builtins ? nixVersion || builtins.compareVersions requiredVersion builtins. | |||
|
|
|||
| - If you are running NixOS, use `nixos-rebuild' to upgrade your system. | |||
|
|
|||
| - Alternatively, with Nix > 2.0 you can use `nix upgrade-nix' to imperatively | |||
There was a problem hiding this comment.
"you can use" to "can be used" in both lines
|
@FRidh: Done. |
matthewbauer
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
With Nix 2.0 out, there is a new way of updating which should be reflected in the message printed to users.
Things done